Skip to content

refactor(taskService): Adding a scheduled executor to retrieve the task status #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(taskService): Adding a scheduled executor to retrieve the task status #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions gate-core/src/main/java/com/netflix/spinnaker/gate/services/TaskService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
import com.netflix.spinnaker.gate.services.internal.OrcaServiceSelector;
import com.netflix.spinnaker.security.AuthenticatedRequest;
import java.util.*;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import lombok.Data;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -37,6 +40,8 @@ public class TaskService {
private ClouddriverServiceSelector clouddriverServiceSelector;
private TaskServiceProperties taskServiceProperties;

@Autowired ExecutorService executorService;

@Autowired
public TaskService(
OrcaServiceSelector orcaServiceSelector,
Expand Down Expand Up @@ -132,10 +137,25 @@ public Map createAndWaitForCompletion(Map body, int maxPolls) {
}

public Map createAndWaitForCompletion(Map body) {
return createAndWaitForCompletion(
body,
taskServiceProperties.getMaxNumberOfPolls(),
taskServiceProperties.getDefaultIntervalBetweenPolls());
CompletableFuture<Map> future =
CompletableFuture.supplyAsync(
() -> {
return createAndWaitForCompletion(
body,
taskServiceProperties.getMaxNumberOfPolls(),
taskServiceProperties.getDefaultIntervalBetweenPolls());
},
executorService)
.thenApply(
result -> {
return result;
});

try {
return future.get();
} catch (InterruptedException | ExecutionException e) {
throw new RuntimeException(e);
}
}

/** @deprecated This pipeline operation does not belong here. */
Expand Down