Skip to content

Commit adc3f41

Browse files
authored
Fix arginfo for getMetadata(), queryWatermarkOffsets() (#494)
1 parent 241a0b7 commit adc3f41

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

kafka_consumer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -756,7 +756,7 @@ PHP_METHOD(RdKafka__KafkaConsumer, offsetsForTimes)
756756
/* {{{ proto void RdKafka\KafkaConsumer::queryWatermarkOffsets(string $topic, int $partition, int &$low, int &$high, int $timeout_ms)
757757
Query broker for low (oldest/beginning) or high (newest/end) offsets for partition */
758758

759-
ZEND_BEGIN_ARG_INFO_EX(arginfo_kafka_kafka_consumer_query_watermark_offsets, 0, 0, 1)
759+
ZEND_BEGIN_ARG_INFO_EX(arginfo_kafka_kafka_consumer_query_watermark_offsets, 0, 0, 5)
760760
ZEND_ARG_INFO(0, topic)
761761
ZEND_ARG_INFO(0, partition)
762762
ZEND_ARG_INFO(1, low)

rdkafka.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ PHP_METHOD(RdKafka__Kafka, addBrokers)
366366

367367
/* {{{ proto RdKafka\Metadata::getMetadata(bool $all_topics, RdKafka\Topic $only_topic, int $timeout_ms)
368368
Request Metadata from broker */
369-
ZEND_BEGIN_ARG_INFO_EX(arginfo_kafka_get_metadata, 0, 0, 1)
369+
ZEND_BEGIN_ARG_INFO_EX(arginfo_kafka_get_metadata, 0, 0, 3)
370370
ZEND_ARG_INFO(0, all_topics)
371371
ZEND_ARG_INFO(0, only_topic)
372372
ZEND_ARG_INFO(0, timeout_ms)
@@ -608,7 +608,7 @@ PHP_METHOD(RdKafka__Kafka, purge)
608608
/* {{{ proto void RdKafka\Kafka::queryWatermarkOffsets(string $topic, int $partition, int &$low, int &$high, int $timeout_ms)
609609
Query broker for low (oldest/beginning) or high (newest/end) offsets for partition */
610610

611-
ZEND_BEGIN_ARG_INFO_EX(arginfo_kafka_query_watermark_offsets, 0, 0, 1)
611+
ZEND_BEGIN_ARG_INFO_EX(arginfo_kafka_query_watermark_offsets, 0, 0, 5)
612612
ZEND_ARG_INFO(0, topic)
613613
ZEND_ARG_INFO(0, partition)
614614
ZEND_ARG_INFO(1, low)

tests/bug74.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ $topic = $consumer->newTopic("batman", null);
1616
$producer = new RdKafka\Producer($conf);
1717

1818
if (class_exists('RdKafka\TopicPartition')) {
19-
$tp = new RdKafka\TopicPartition("batman", 0, null);
19+
$tp = new RdKafka\TopicPartition("batman", 0, 0);
2020
}
2121
--EXPECT--

0 commit comments

Comments
 (0)