Skip to content

Conversation

@resivalex
Copy link

@resivalex resivalex commented Jul 3, 2022

Resolves #4
Resolves #2 for modern browsers

  • Fixed component margins.
  • Installed streamlit-component-lib and removed excess source files.
  • Removed an excess call of Streamlit.setComponentValue in componentDidMount.
  • Made a notebook link open in new tab.
  • Added debounce option and debounced component updates.
  • Improved resize handling

@resivalex
Copy link
Author

@asg017 Take a look please. Could you update the package?

@asg017
Copy link
Owner

asg017 commented Jul 28, 2022

Hey @resivalex , apologies for the delay, and thank you for this contribution! I will review this and will most likely merge it in, but it's a while since I've kept up with the new Streamlit component APIs (streamlit-component-lib is new to me) and I honestly forgot how to update packages on pypi, so it may take some time to get up to speed.

But again, thanks for this PR, it definitely cleans up a lot from this project!

@resivalex
Copy link
Author

Hi @asg017. Maybe I can help somehow. Let's update the package.

@resivalex
Copy link
Author

Hey @asg017, could you take a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debounce updates from component Observables of dynamic height get cut off (i.e. frame height changes are not being passed back to Streamlit)

2 participants