Skip to content

Conversation

shelegdmitriy
Copy link
Member

No description provided.

@shelegdmitriy shelegdmitriy force-pushed the chore/add-more-examples-for-testing branch from 0bdb160 to 8a58965 Compare April 22, 2025 18:58
@shelegdmitriy shelegdmitriy requested a review from Copilot April 22, 2025 18:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces benchmark examples for the GraphViz component rendering by adjusting how data is processed based on the collapsible prop and updating the example configuration.

  • Updated the initial state logic in GraphViz.tsx to conditionally prune the data.
  • Adjusted the example in App.tsx to use a different dataset and explicitly set the collapsible prop.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/lib/Graph/GraphViz.tsx Changed state initialization logic to use a ternary based on the collapsible prop.
examples/App.tsx Updated dataset import and added comments for generating random benchmark tree data; added explicit collapsible prop.
Comments suppressed due to low confidence (1)

src/lib/Graph/GraphViz.tsx:40

  • Ensure that the data returned when 'collapsible' is false matches the expected structure of prunedData, as getPrunedTree may produce a different shape than the original data. Consider introducing a transformation or type check to maintain consistency.
collapsible ? getPrunedTree(nodesById, rootId) : data

@shelegdmitriy shelegdmitriy merged commit bf8dae0 into main Apr 22, 2025
1 check passed
@shelegdmitriy shelegdmitriy deleted the chore/add-more-examples-for-testing branch April 22, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant