Skip to content

Commit f53c08f

Browse files
JesseTatasciorejbedard
authored andcommitted
fix(CLI): Set BES completion timeout to 60 seconds (#7295)
When the `bazel lint` run finishes and we are waiting for the BES to complete, we had a 60 millisecond timeout. Increase this timeout to 60 seconds. Hit this timeout at a customer when we should not have Customer thread: https://aspect-build.slack.com/archives/C03LLCZPA3D/p1728675490951849 --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Increase linting BES completion timeout to 60 seconds ### Test plan - Covered by existing test cases GitOrigin-RevId: 851b34257be6577ebf5358ba9c43d6121ccc1698
1 parent b889723 commit f53c08f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/aspect/lint/lint.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ lint:
263263
// Wait for BES completion event for some maximum amount fo time
264264
select {
265265
case <-besCompleted:
266-
case <-time.After(60 * time.Millisecond):
266+
case <-time.After(60 * time.Second):
267267
return fmt.Errorf("timed out waiting for build completed event")
268268
}
269269

0 commit comments

Comments
 (0)