Skip to content

chore: add windows_arm64 support #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dennisameling
Copy link

Closes #841

Marking as draft as this seems to be missing a dependency in rules_js (will file a separate PR there):

ERROR: Traceback (most recent call last):
	File "C:/_bazel/external/aspect_rules_js~/npm/extensions.bzl", line 34, column 41, in _npm_extension_impl
		_npm_lock_imports_bzlmod(module_ctx, attr)
	File "C:/_bazel/external/aspect_rules_js~/npm/extensions.bzl", line 79, column 41, in _npm_lock_imports_bzlmod
		state = npm_translate_lock_state.new(attr.name, module_ctx, attr, True)
	File "C:/_bazel/external/aspect_rules_js~/npm/private/npm_translate_lock_state.bzl", line 590, column 10, in _new
		_init(priv, rctx, attr, label_store)
	File "C:/_bazel/external/aspect_rules_js~/npm/private/npm_translate_lock_state.bzl", line 37, column 24, in _init
		_init_common_labels(priv, rctx, attr, label_store, is_windows)
	File "C:/_bazel/external/aspect_rules_js~/npm/private/npm_translate_lock_state.bzl", line 119, column 20, in _init_common_labels
		label_store.add("host_yq", Label("@{}_{}//:yq{}".format(attr.yq_toolchain_prefix, repo_utils.platform(rctx), ".exe" if is_windows else "")))
	File "C:/_bazel/external/aspect_rules_js~/npm/private/repository_label_store.bzl", line 104, column 57, in lambda
		add = lambda key, label, seed_root = False: _add(priv, rctx_path, repo_root, key, label, seed_root),
	File "C:/_bazel/external/aspect_rules_js~/npm/private/repository_label_store.bzl", line 39, column 39, in _add
		priv["paths"][key] = str(rctx_path(label))
Error in path: Unable to load package for @@[unknown repo 'yq_windows_arm64' requested from @@aspect_rules_js~]//:yq.exe: The repository '@@[unknown repo 'yq_windows_arm64' requested from @@aspect_rules_js~]' could not be resolved: No repository visible as '@yq_windows_arm64' from repository '@@aspect_rules_js~'

Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

aspect-workflows bot commented Jul 13, 2025

Test

All tests were cache hits

234 tests (100.0%) were fully cached saving 8m 40s.


Buildifier      Format

@dennisameling dennisameling changed the title Add Windows arm64 support chore: add windows_arm64 support Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add arm64 target for Windows
2 participants