File tree Expand file tree Collapse file tree 2 files changed +34
-12
lines changed
js/private/test/node-patches Expand file tree Collapse file tree 2 files changed +34
-12
lines changed Original file line number Diff line number Diff line change @@ -77,6 +77,13 @@ node_dev = use_extension(
7777 "node" ,
7878 dev_dependency = True ,
7979)
80+ use_repo (node_dev , "node16_linux_amd64" )
81+ use_repo (node_dev , "node16_darwin_arm64" )
82+ use_repo (node_dev , "node16_darwin_amd64" )
83+ use_repo (node_dev , "node16_linux_arm64" )
84+ use_repo (node_dev , "node16_linux_s390x" )
85+ use_repo (node_dev , "node16_linux_ppc64le" )
86+ use_repo (node_dev , "node16_windows_amd64" )
8087use_repo (node_dev , "node18_linux_amd64" )
8188use_repo (node_dev , "node18_darwin_arm64" )
8289use_repo (node_dev , "node18_darwin_amd64" )
@@ -106,6 +113,10 @@ use_repo(node_dev, "node24_linux_s390x")
106113use_repo (node_dev , "node24_linux_ppc64le" )
107114use_repo (node_dev , "node24_windows_amd64" )
108115node_dev .toolchain (node_version = "18.20.4" )
116+ node_dev .toolchain (
117+ name = "node16" ,
118+ node_version = "16.20.0" ,
119+ )
109120node_dev .toolchain (
110121 name = "node18" ,
111122 node_version = "18.20.4" ,
Original file line number Diff line number Diff line change @@ -12,6 +12,7 @@ TESTS = [
1212
1313# Multiple node toolchains for testing across versions
1414TOOLCHAINS_NAMES = [
15+ "node16" ,
1516 "node18" ,
1617 "node20" ,
1718 "node22" ,
@@ -40,19 +41,29 @@ TOOLCHAINS_VERSIONS = [
4041
4142# Basic tests
4243[
43- js_test (
44- name = "{}_test" .format (t .replace (".js" , "" )),
45- data = [
46- "//:node_modules/inline-fixtures" ,
47- "//js/private/node-patches/src:compile" ,
48- ],
49- entry_point = "copy_entry_{}" .format (t ),
50- patch_node_fs = False ,
51- # Without node patches on for these tests, the program is going to escape the sandbox if it
52- # is on since the fs patches are not on for the tests as they are the code under test
53- tags = ["no-sandbox" ],
44+ [
45+ js_test (
46+ name = "{}_{}_test" .format (
47+ t .replace (".js" , "" ),
48+ toolchain_name ,
49+ ),
50+ data = [
51+ "//:node_modules/inline-fixtures" ,
52+ "//js/private/node-patches/src:compile" ,
53+ ],
54+ entry_point = "copy_entry_{}" .format (t ),
55+ node_toolchain = toolchain ,
56+ patch_node_fs = False ,
57+ # Without node patches on for these tests, the program is going to escape the sandbox if it
58+ # is on since the fs patches are not on for the tests as they are the code under test
59+ tags = ["no-sandbox" ],
60+ )
61+ for t in TESTS
62+ ]
63+ for toolchain_name , toolchain in zip (
64+ TOOLCHAINS_NAMES ,
65+ TOOLCHAINS_VERSIONS ,
5466 )
55- for t in TESTS
5667]
5768
5869# Node process spawning tests
You can’t perform that action at this time.
0 commit comments