Skip to content

rules_js v3 BREAKING CHANGES #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbedard opened this issue Oct 18, 2024 · 0 comments
Open

rules_js v3 BREAKING CHANGES #1993

jbedard opened this issue Oct 18, 2024 · 0 comments
Assignees
Labels
breaking Requires a semver-major release due to breaking public API changes tracking issue This is a tracking issue

Comments

@jbedard
Copy link
Member

jbedard commented Oct 18, 2024

BREAKING CHANGES for next major release of rules_js:

MAYBE:

  • simplify internal package store rules and make circular-dep handling opt-in?
  • split npm_link_all_packages store vs link targets into different marcos: store targets (root only), :node_modules/{pkg} targets within each package directory such as @npm//my/project:defs.bzl

LARGE (but should be non-breaking):

@jbedard jbedard added the breaking Requires a semver-major release due to breaking public API changes label Oct 18, 2024
@jbedard jbedard self-assigned this Oct 18, 2024
@gregmagolan gregmagolan added the tracking issue This is a tracking issue label Oct 18, 2024
@gregmagolan gregmagolan changed the title rules_js v3 breaking changes rules_js v3 BREAKING CHANGES Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Requires a semver-major release due to breaking public API changes tracking issue This is a tracking issue
Projects
None yet
Development

No branches or pull requests

2 participants