Skip to content

Remove ability to customize virtual store name #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbedard opened this issue Apr 24, 2025 · 0 comments · May be fixed by #2202
Open

Remove ability to customize virtual store name #2196

jbedard opened this issue Apr 24, 2025 · 0 comments · May be fixed by #2202
Assignees
@jbedard
Labels
breaking Requires a semver-major release due to breaking public API changes

Comments

@jbedard
Copy link
Member

jbedard commented Apr 24, 2025 •
edited
Loading

Today npm_link_all_packages(name) can be used to specify:

  • the link_root_name in .aspect_rules_js/{link_root_name}/package_key
  • the :{link_root_name}/package_name

This allows multiple npm repositories (lockfiles) to be linked into the same directory - multiple npm_link_all_packages invocations in the same BUILD. This feature is most likely never or rarely used, yet causes many strings to be constructed dynamically.
@jbedard jbedard added the breaking Requires a semver-major release due to breaking public API changes label Apr 24, 2025
@jbedard jbedard mentioned this issue Apr 23, 2025
Open
@jbedard jbedard self-assigned this Apr 25, 2025
jbedard added a commit to jbedard/rules_js that referenced this issue Apr 25, 2025
@jbedard
feat: remove the ability to customize node_modules path
d4f0951 
Fix aspect-build#2196
@jbedard jbedard linked a pull request Apr 25, 2025 that will close this issue
Draft
jbedard added a commit to jbedard/rules_js that referenced this issue Apr 28, 2025
@jbedard
feat: remove the ability to customize node_modules path
48047e1 
Fix aspect-build#2196
jbedard added a commit to jbedard/rules_js that referenced this issue Apr 28, 2025
@jbedard
feat: remove the ability to customize node_modules path
62b009d 
Fix aspect-build#2196
jbedard added a commit to jbedard/rules_js that referenced this issue Apr 29, 2025
@jbedard
feat: remove the ability to customize node_modules path
4642422 
Fix aspect-build#2196
@jbedard jbedard mentioned this issue Apr 30, 2025
Merged
jbedard added a commit to jbedard/rules_js that referenced this issue May 1, 2025
@jbedard
feat: remove the ability to customize node_modules path
c0055f9 
Fix aspect-build#2196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
breaking Requires a semver-major release due to breaking public API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove the ability to customize node_modules path jbedard/rules_js
1 participant
@jbedard