-
-
Notifications
You must be signed in to change notification settings - Fork 150
feat: support prod and dev deps on npm_link_all_packages and npm_link_targets #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 17 commits
eeeff5a
55ef0a5
bfd6d12
c60c396
c39c3ff
147b3bf
13a05e2
e1512a2
f3157c6
c154f5e
ba418fe
ce5d49d
1724cf5
f112ad7
154b9a7
75230ef
e044528
c1db964
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Crash if dev deps missing | ||
| require('@rollup/plugin-commonjs'); | ||
| require('@rollup/plugin-json'); | ||
| require('@rollup/plugin-node-resolve'); | ||
|
|
||
| // Crash if prod deps present (filtering failed) | ||
| try { | ||
| require('debug'); | ||
| throw new Error('PROD DEPENDENCY LEAKED INTO DEV BUILD'); | ||
| } catch (e) { | ||
| if (e.code !== 'MODULE_NOT_FOUND') throw e; | ||
| } | ||
|
|
||
| console.log('✅ Development filtering validated'); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Crash if prod deps missing | ||
| require('debug'); | ||
| require('is-odd'); | ||
| require('semver'); | ||
|
|
||
| // Crash if dev deps present (filtering failed) | ||
| try { | ||
| require('@rollup/plugin-commonjs'); | ||
| throw new Error('DEV DEPENDENCY LEAKED INTO PROD BUILD'); | ||
| } catch (e) { | ||
| if (e.code !== 'MODULE_NOT_FOUND') throw e; | ||
| } | ||
|
|
||
| console.log('✅ Production filtering validated'); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.