Skip to content

Conversation

peakschris
Copy link

@peakschris peakschris commented Aug 21, 2025

Changes:

  • Fix js_binary to run on windows without bash; works both in js_image_layer and via bazel
  • Disable failing tests due to windows or --noenable_runfiles
  • Enable windows CI
  • Bump aspect_bazel_lib and tar.bzl to fix windows tar toolchain issues

@aspect-workflows
Copy link

aspect-workflows bot commented Aug 21, 2025

Test

⚠️ Buildkite build #9685 failed.

//js/private/test/image:tar_listing failed to build

failed to create symbolic link 'bazel-out/k8-opt-exec-ST-d57f47055a04/bin/js/private/test/image/tar_listing': file 'js/private/test/image/tar_listing.sh' is not executable
failed to create symbolic link 'bazel-out/k8-fastbuild/bin/js/private/test/image/tar_listing': file 'js/private/test/image/tar_listing.sh' is not executable
Failed tests (2)
//js/private/test/image:checksum_test_test_test [k8-fastbuild]                🔗
//js/private/test:write_launcher_test [k8-fastbuild]                          🔗

💡 To reproduce the build failures, run

bazel build //js/private/test/image:tar_listing //js/private/test/image:tar_listing

💡 To reproduce the test failures, run

bazel test //js/private/test/image:checksum_test_test_test //js/private/test:write_launcher_test

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 543ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 206ms.


Test

e2e/js_image_oci

⚠️ Buildkite build #9685 failed.

Failed tests (1)
//src:image_test [k8-fastbuild]                                               🔗

💡 To reproduce the test failures, run

bazel test //src:image_test

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 413ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 402ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 380ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 115ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 298ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 9s.


Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 4s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 501ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 259ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 76ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 169ms.


Buildifier      Format

@peakschris
Copy link
Author

@alexeagle could you take a look at / rerun the one failing job? Looks like an environment issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant