Draft
Conversation
An example which allows configuring internal details of the formatter. Replaces the switch statement in format.sh with a JSON that is handled. (dont love depending on jq here). Obviously a lot more is needed for this to be accepted: doc work, porting over mirror_linguist_languages.sh, a format_config or format_extensions function within defs.bzl. Testing was done by running bazel run format_custom within the test folder and seeing the .bozo file getting processed by the mock yaml formatter. ``` penne[130][test] $ pwd /home/boin/Projects/tools/tools/rules_lint/format/test penne[000][test] $ bazel run format_custom INFO: Analyzed target //format/test:format_custom (0 packages loaded, 0 targets configured). INFO: Found 1 target... Target //format/test:format_custom up-to-date: bazel-bin/format/test/format_custom.bash INFO: Elapsed time: 0.093s, Critical Path: 0.00s INFO: 1 process: 1 internal. INFO: Build completed successfully, 1 total action INFO: Running command line: bazel-bin/format/test/format_custom.bash + yamlfmt example/hello.bozo Formatted YAML in 0m0.022s ```
Contributor
|
Very cool. I'll sign the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created from a commit by @b0inbot :