fix(venv_link): Restore original venv name mangling (#589)

Reported by @jimmyt857 in testing of v1.6.0-rc0

Previously running the `examples/py_binary:py_binary.venv` target would
create a link
`$BUILD_WORKING_DIRECTORY/.examples+py_binary+py_binary.venv`. This
behavior regressed in 1.5.0 and the link became simply
`$BUILD_WORKING_DIRECTORY/.py_binary.venv`.

Restore the original behavior.

---

### Changes are visible to end-users: no

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: no

### Test plan

- [x] Manual testing

```shellsession
❯ bazel run //examples/py_binary:py_binary.venv
INFO: Analyzed target //examples/py_binary:py_binary.venv (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //examples/py_binary:py_binary.venv up-to-date:
  bazel-bin/examples/py_binary/py_binary.venv
INFO: Elapsed time: 0.815s, Critical Path: 0.05s
INFO: 2 processes: 1 internal, 1 darwin-sandbox.
INFO: Build completed successfully, 2 total actions
INFO: Running command line: bazel-bin/examples/py_binary/py_binary.venv
usage: link [options]

Helper to create a symlink to a virtualenv in the source tree.

optional arguments:
  -h, --help   show this help message and exit
  --dest DEST  Dir to link the virtualenv into. Default is $BUILD_WORKING_DIRECTORY. (default: /Users/arrdem/Documents/work/aspect/rules_py)
  --name NAME  Name to link the virtualenv as. (default: .examples+py_binary+py_binary.venv)

Linking: /private/var/tmp/_bazel_arrdem/93bfea6cdc1153cc29a75400cd38823a/execroot/aspect_rules_py/bazel-out/darwin_arm64-fastbuild/bin/examples/py_binary/.py_binary.venv -> /Users/arrdem/Documents/work/aspect/rules_py/.examples+py_binary+py_binary.venv

Link is up to date!

To configure the virtualenv in your IDE, configure an interpreter with the homedir
    /Users/arrdem/Documents/work/aspect/rules_py/.examples+py_binary+py_binary.venv

To activate the virtualenv in your shell run
    source /Users/arrdem/Documents/work/aspect/rules_py/.examples+py_binary+py_binary.venv/bin/activate
```

Author: arrdem

py/private/py_venv/link.py

@@ -15,47 +15,43 @@
 virtualenv_name = os.path.basename(virtualenv_home)
 runfiles_dir = os.path.realpath(os.environ["RUNFILES_DIR"])
 builddir = os.path.realpath(os.environ["BUILD_WORKING_DIRECTORY"])
-
-# Chop off the runfiles tree prefix
-virtualenv_path = virtualenv_home.lstrip(runfiles_dir).lstrip("/")
-# Chop off the repo name to get a repo-relative path
-virtualenv_path = virtualenv_path[virtualenv_path.find("/"):]
+target_package, target_name = os.environ["BAZEL_TARGET"].split("//", 1)[1].split(":")
 
 PARSER = argparse.ArgumentParser(
     prog="link",
     usage=__doc__,
+    formatter_class=argparse.ArgumentDefaultsHelpFormatter,
 )
 
 PARSER.add_argument(
-    "--venv-name",
-    dest="venv_name",
-    default=virtualenv_name,
-    help="Name to link the virtualenv under.",
+    "--dest",
+    dest="dest",
+    default=builddir,
+    help="Dir to link the virtualenv into. Default is $BUILD_WORKING_DIRECTORY.",
 )
 
 PARSER.add_argument(
-    "--dest",
-    dest="dest",
-    default=os.path.join(builddir, os.path.dirname(virtualenv_path)),
-    help="Dir to link the virtualenv into",
+    "--name",
+    dest="name",
+    default=".{}+{}".format(target_package.replace("/", "+"), virtualenv_name.lstrip(".")),
+    help="Name to link the virtualenv as.",
 )
 
+
 if __name__ == "__main__":
+    PARSER.print_help(sys.stdout)
     opts = PARSER.parse_args()
-    dest = Path(os.path.join(opts.dest, opts.venv_name))
-    print("""\
-Linking: {venv_home} -> {venv_path}
+    dest = Path(os.path.join(opts.dest, opts.name))
+    print("""
 
-To activate the virtualenv run:
-    source {venv_path}/bin/activate
+Linking: {venv_home} -> {venv_path}
 """.format(
     venv_home = virtualenv_home,
     venv_path = dest,
 ))
 
     if dest.exists() and dest.is_symlink() and dest.readlink() == Path(virtualenv_home):
         print("Link is up to date!")
-        exit(0)
 
     else:
         try:
@@ -67,4 +63,22 @@
         # From -> to
         dest.symlink_to(virtualenv_home, target_is_directory=True)
         print("Link created!")
-        exit(0)
+
+    print("""
+To configure the virtualenv in your IDE, configure an interpreter with the homedir
+    {venv_path}
+
+    Please note that you may encounter issues if your editor doesn't evaluate
+    the `activate` script. If you do please file an issue at
+    https://github.com/aspect-build/rules_py/issues/new?template=BUG-REPORT.yaml
+
+To activate the virtualenv in your shell run
+    source {venv_path}/bin/activate
+
+virtualenvwrapper users may further want to
+    $ ln -s {venv_path} $WORKON_HOME/{venv_name}
+""".format(
+    venv_home = virtualenv_home,
+    venv_name = opts.name,
+    venv_path = dest,
+))