Skip to content

tweak(ci): Automate pre-commit runs #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arrdem
Copy link
Collaborator

@arrdem arrdem commented Jun 6, 2025

This is an opinionated change, and to be very clear the opinion is mine. Linters which can also do formatting should not be allowed to break CI. If there is a programmatically defined "right way" things should be done and tooling can do it, no purpose is served in making a human rerun a tool to apply that formatting.

Extend the pre-commit CI step so that it will commit (as @aspect-marvin) any formatting changes and push them back to the branch.

The motivation for doing this isn't just my own annoyance with pushing lint commits, but also so that PRs from @renovate-bot will trigger updates to the Gazelle manifest (or other code) so that those PRs can auto-merge.


Changes are visible to end-users: no

Test plan

N/A.

Copy link

aspect-workflows bot commented Jun 6, 2025

Test

All tests were cache hits

39 tests (100.0%) were fully cached saving 1m 10s.

Copy link

github-actions bot commented Jun 6, 2025

e2e/use_release folder: LCOV of commit 781e6da during CI #1843

Summary coverage rate:
  lines......: 100.0% (2 of 2 lines)
  functions..: 100.0% (1 of 1 function)
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant