tweak(ci): Automate pre-commit runs #585
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an opinionated change, and to be very clear the opinion is mine. Linters which can also do formatting should not be allowed to break CI. If there is a programmatically defined "right way" things should be done and tooling can do it, no purpose is served in making a human rerun a tool to apply that formatting.
Extend the
pre-commit
CI step so that it will commit (as @aspect-marvin) any formatting changes and push them back to the branch.The motivation for doing this isn't just my own annoyance with pushing lint commits, but also so that PRs from @renovate-bot will trigger updates to the Gazelle manifest (or other code) so that those PRs can auto-merge.
Changes are visible to end-users: no
Test plan
N/A.