Provide bazelrc preset definition #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we want to include https://registry.bazel.build/modules/bazelrc-preset.bzl as dev dependency to validate that the flags.bzl work |
hofbi
commented
Jul 24, 2025
alexeagle
reviewed
Jul 24, 2025
alexeagle
reviewed
Jul 24, 2025
hofbi
commented
Jul 24, 2025
hofbi
commented
Jul 24, 2025
This was referenced Jul 24, 2025
fmeum
approved these changes
Jul 24, 2025
alexeagle
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel-contrib/bazelrc-preset.bzl#62 introduced the new
extra_presetsattribute. Now this project can define its relevant presets in a compatible datastructure so that it can be included in the bazelrc presets.Another benefit: In case the presets of this project change and users update to a more recent version, the diff test of
bazelrc_presetwill fail and make them aware of the changes. Else they might miss them unless they review the release notes or README again.