Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades TensorFlow Lite libraries to v2.19.0, adds new delegate features, consolidates type definitions, and updates package metadata and binaries.
- Bump core TFLite C API and Unity plugin versions to 2.19.0
- Introduce new Slinky flag, in-memory weight cache APIs, metadata access, and new built-in ops
- Remove deprecated headers, consolidate type enums into
tflite_types.h, and clean up operator API
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Packages/.../xnnpack_delegate.h | Added Slinky flag and in-memory weight cache API methods |
| Packages/.../tflite_types.h | New header defining TfLiteType, quantization params, and dimension types |
| Packages/.../registration_external.h | Deleted deprecated external registration API header |
| Packages/.../operator.h | Cleaned up operator creation API; potential name collision |
| Packages/.../common.h | Extended external contexts, added unreachable macros and bf16 union |
| Packages/.../c_api_types.h | Moved type enums to tflite_types.h, added kTfLiteOutputShapeNotKnown |
| Packages/.../c_api_opaque.h | Added GetExternalContext and GetMetadata C API functions |
| Packages/.../c_api_experimental.h | Fixed typo in experimental API documentation |
| Packages/.../builtin_ops.h | Added new StableHLO ops: ShiftLeft, Cbrt, Case |
| Packages/.../TensorFlowLiteC.h | Imported new tflite_types.h |
| Packages/.../package.json (common & mediapipe) | Bumped Unity package versions to 2.19.0 |
| Packages/.../*.dll / *.so / *.aar | Updated library binary blobs for Windows, Linux, and Android |
| Packages/.../arm64-v8a/libtensorflowlite_gpu_gl.so.meta | Adjusted Android plugin importer settings |
Comments suppressed due to low confidence (3)
Packages/com.github.asus4.tflite/Plugins/iOS/TensorFlowLiteC.framework/Headers/operator.h:85
- The function
TfLiteOperatorCreateis now declared twice in this C header (once for three parameters and once for four), which causes a name collision. Restore a unique name (e.g.,TfLiteOperatorCreateWithData) for the overload that acceptsuser_data.
TFL_CAPI_EXPORT extern TfLiteOperator* TfLiteOperatorCreate(
Packages/com.github.asus4.tflite/Plugins/iOS/TensorFlowLiteC.framework/Headers/common.h:325
- Using
enum ... : intis valid in C++ but not in standard C. To maintain C compatibility for this API header, remove the: intqualifier or conditionally guard it under#ifdef __cplusplus.
typedef enum TfLiteQuantizationType : int {
Packages/com.github.asus4.tflite/Plugins/Android/arm64-v8a/libtensorflowlite_gpu_gl.so.meta:19
- The metadata sets
Exclude Android: 1for an ARM64 Android library, which will prevent it from being included in Android builds. Set this flag to0to ensure the plugin is packaged correctly for Android.
Exclude Android: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.