Skip to content

Remove NPM_TOKEN from publishing script#403

Merged
asus4 merged 4 commits intomasterfrom
npm-oidc-publish
Sep 8, 2025
Merged

Remove NPM_TOKEN from publishing script#403
asus4 merged 4 commits intomasterfrom
npm-oidc-publish

Conversation

@asus4
Copy link
Copy Markdown
Owner

@asus4 asus4 commented Sep 8, 2025

No description provided.

@asus4 asus4 requested a review from Copilot September 8, 2025 08:34
@asus4 asus4 self-assigned this Sep 8, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the NPM_TOKEN secret authentication in favor of OIDC token-based authentication for NPM package publishing, enhancing security by eliminating the need for long-lived secrets.

  • Adds OIDC permissions (id-token: write, contents: read) to enable token-based authentication
  • Updates Node.js setup action from v4 to v5 with latest node version
  • Removes NODE_AUTH_TOKEN environment variables from all publish steps
Comments suppressed due to low confidence (1)

.github/workflows/publish-packages.yaml:1

  • The OIDC authentication setup is incomplete. You need to configure npm with provenance and set up the registry authentication. Add --provenance --access public to npm publish commands and ensure the registry is properly configured for OIDC authentication.
name: Publish UPM packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/publish-packages.yaml
@asus4 asus4 marked this pull request as ready for review September 8, 2025 09:18
@asus4 asus4 merged commit ab09322 into master Sep 8, 2025
1 check passed
@asus4 asus4 deleted the npm-oidc-publish branch September 8, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants