Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the NPM_TOKEN secret authentication in favor of OIDC token-based authentication for NPM package publishing, enhancing security by eliminating the need for long-lived secrets.
- Adds OIDC permissions (
id-token: write,contents: read) to enable token-based authentication - Updates Node.js setup action from v4 to v5 with latest node version
- Removes
NODE_AUTH_TOKENenvironment variables from all publish steps
Comments suppressed due to low confidence (1)
.github/workflows/publish-packages.yaml:1
- The OIDC authentication setup is incomplete. You need to configure npm with provenance and set up the registry authentication. Add
--provenance --access publicto npm publish commands and ensure the registry is properly configured for OIDC authentication.
name: Publish UPM packages
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.