AddTypeScript adds node_modules directory

To avoid requiring users to install NPM and run `npm install`, we
include the node_modules directory when adding TypeScript support to a
Rug project using the AddTypeScript editor.

Migrate AddTypeScript editor to TypeScript.

Export constants (`const`) rather than variables (`let`) from
TypeScript Rugs.

Author: David Dooling

.atomist.yml

@@ -103,3 +103,19 @@ editor:
   parameters:
     - "editor_name": "AddAtomistCopyright"
 
+---
+kind: "operation"
+client: "rug-cli 0.24.0"
+editor:
+  name: "atomist-rugs.rug-editors.AddTypeScriptEditor"
+  group: "atomist-rugs"
+  artifact: "rug-editors"
+  version: "0.9.0"
+  origin:
+    repo: "https://github.com/atomist-rugs/rug-editors.git"
+    branch: "82acbef9ce2c04e0cb6316b9fde702a89469a85b"
+    sha: "82acbef"
+  parameters:
+    - "editor_name": "AddTypeScript"
+    - "description": "adds TypeScript supporting files to a Rug archive project"
+

.atomist/editors/AddTypeScript.rug

@@ -0,0 +1,42 @@
+/*
+ * Copyright © 2017 Atomist, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { EditProject } from '@atomist/rug/operations/ProjectEditor'
+import { Project } from '@atomist/rug/model/Core'
+import { Pattern } from '@atomist/rug/operations/RugOperation'
+import { Editor, Tags } from '@atomist/rug/operations/Decorators'
+
+@Editor("AddTypeScript", "adds TypeScript supporting files to a Rug archive project")
+@Tags("rug", "typescript")
+class AddTypeScript implements EditProject {
+
+    edit(project: Project) {
+        if (!project.fileExists(".atomist/manifest.yml")) {
+            return;
+        }
+
+        let packageJsonPath = ".atomist/package.json";
+        let tsconfigJsonPath = ".atomist/tsconfig.json";
+        let gitignorePath = ".atomist/.gitignore";
+        let nodeModulesPath = ".atomist/node_modules";
+        project.copyEditorBackingFileOrFail(packageJsonPath);
+        project.copyEditorBackingFileOrFail(tsconfigJsonPath);
+        project.copyEditorBackingFileOrFail(gitignorePath);
+        project.copyEditorBackingFilesPreservingPath(nodeModulesPath);
+    }
+}
+
+export const addTypeScript = new AddTypeScript()

.atomist/editors/AddTypeScript.ts

@@ -79,4 +79,4 @@ class AddTypeScriptGenerator implements EditProject {
     }
 }
 
-export let addTypeScriptGenerator = new AddTypeScriptGenerator()
+export const addTypeScriptGenerator = new AddTypeScriptGenerator()

.atomist/editors/AddTypeScriptGenerator.ts

@@ -22,4 +22,4 @@ class HelloTypeScript implements EditProject {
     }
 }
 
-export let helloTypeScript = new HelloTypeScript()
+export const helloTypeScript = new HelloTypeScript()

.atomist/editors/HelloTypeScript.ts

@@ -23,4 +23,4 @@ class TypeScriptGenerator implements PopulateProject {
     }
 }
 
-export let typeScriptGenerator = new TypeScriptGenerator();
+export const typeScriptGenerator = new TypeScriptGenerator();

.atomist/editors/TypeScriptGenerator.ts

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2016 Atomist, Inc.
+ * Copyright © 2017 Atomist, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,27 +31,8 @@ then
     and fileContains ".atomist/tsconfig.json" "suppressImplicitAnyIndexErrors"
     and fileExists ".atomist/.gitignore"
     and fileContains ".atomist/.gitignore" "node_modules"
-
-
-scenario AddTypeScript should add support files for writing Rugs in TypeScript with a specific version of Rug
-
-let rug_version = "0.9.0"
-
-given
-  .atomist/manifest.yml = """requires: "0.11.0"
-"""
-
-when
-  AddTypeScript
-
-then
-  fileExists ".atomist/package.json"
-    and fileContains ".atomist/package.json" '"@atomist/rug"'
-    and fileContains ".atomist/package.json" '"0.9.0"'
-    and fileExists ".atomist/tsconfig.json"
-    and fileContains ".atomist/tsconfig.json" "suppressImplicitAnyIndexErrors"
-    and fileExists ".atomist/.gitignore"
-    and fileContains ".atomist/.gitignore" "node_modules"
+    and directoryExists ".atomist/node_modules/@atomist/rug"
+    and fileExists ".atomist/node_modules/@atomist/rug/model/Core.ts"
 
 
 scenario AddTypeScript should not make any changes if the target project is not a Rug archive

.atomist/tests/AddTypeScript.rt

@@ -7,12 +7,24 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
-[Unreleased]: https://github.com/atomist-rugs/rug-editors/compare/0.9.0...HEAD
+[Unreleased]: https://github.com/atomist-rugs/rug-editors/compare/0.10.0...HEAD
+
+## [0.10.0] - 2017-02-24
+
+[0.10.0]: https://github.com/atomist-rugs/rug-editors/compare/0.9.0...0.10.0
+
+### Added
+
+-   AddTypeScript adds .atomist/node_modules
 
 ### Changed
 
 -   AddTypeScript now adds an appropriate .gitignore
 
+-   AddTypeScript is now in TypeScript
+
+-   TypeScript Rugs export constants rather than variables
+
 ## [0.9.0] - 2017-02-17
 
 [0.9.0]: https://github.com/atomist-rugs/rug-editors/compare/0.8.0...0.9.0

CHANGELOG.md

@@ -129,24 +129,20 @@ satisfied.
 
 #### Parameters
 
-To run this Editor, you must supply the following parameters.
-
-Name | Required | Default | Description
------|----------|---------|------------
-`rug_version` | No | 0.12.0 | A valid Rug version following NPM version semantics, https://docs.npmjs.com/misc/semver.
+This editor has no parameters.
 
 #### Running
 
 Run it as follows:
 
 ```
 $ cd rug/archive/directory
-$ rug edit atomist-rugs:rug-editors:AddTypeScript \
-    rug_version=0.12.0
+$ rug edit atomist-rugs:rug-editors:AddTypeScript
 ```
 
-This will add the files `.atomist/package.json` and
-`.atomist/tsconfig.json` to the project.
+This will add `package.json`, `tsconfig.json`, and `.gitignore` files
+and the `node_modules` directory to the `.atomist` directory in the
+project.
 
 ### AddTypeScriptEditor