chore: automated noports desktop builds #1626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtlyCritchlow
changed the title
XavierChanth
reviewed
Feb 3, 2025
Comment on lines
+3
to
+6
| on: | ||
| push: | ||
| branches: | ||
| - trunk |
There was a problem hiding this comment.
This should be on tag d*.*.* (d for desktop) & optionally on workflow_dispatch. We shouldn't rebuild the app everytime something is pushed to trunk
XavierChanth
reviewed
Feb 3, 2025
| name: Windows Build | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
See some of the other workflows, please use commit SHAs (for all of the uses statements)
XavierChanth
reviewed
Feb 3, 2025
Comment on lines
+24
to
+28
| - name: Build msix file with Dart SDK | ||
| uses: dart-lang/setup-dart@v1 | ||
| with: | ||
| sdk: stable | ||
| - run: dart run msix:create |
There was a problem hiding this comment.
prefer calling all of the setup environment uses first, then do all of the runs.
There was a problem hiding this comment.
You also don't need to setup dart if you've already setup flutter. Dart binary is installed with Flutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added automation build for msix for no ports Desktop
- How I did it
- How to verify it
- Description for the changelog