Skip to content

Return endPoint along with selected indices #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return endPoint along with selected indices #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ The should exist before rendering the `Selection` component.

#### `onSelectionChange`

Function that will be executed when the selection changes. An array of element indexes will be passed (with the same indexes as the `elements` prop).
Function that will be executed when the selection changes. An array of element indexes will be passed (with the same indexes as the `elements` prop) as the first argument. The second argument will contain the dragging `endPoint` object with `x` and `y` values.

This is where you want to update your state, to highlight them as selected for example.

Expand Down
6 changes: 4 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export type Box = {
type Props = {
disabled?: boolean,
target: HTMLElement,
onSelectionChange?: (elements: Array<any>) => void,
onSelectionChange?: (elements: Array<any>, point: Point) => void,
onHighlightChange?: (elements: Array<any>) => void,
elements: Array<HTMLElement>,
// eslint-disable-next-line react/no-unused-prop-types
Expand Down Expand Up @@ -189,6 +189,8 @@ export default class Selection extends React.PureComponent<Props, State> { // es
window.document.removeEventListener('mouseup', this.onMouseUp);
window.document.removeEventListener('touchend', this.onMouseUp);

const endPoint = {...this.state.endPoint};

this.setState({
mouseDown: false,
startPoint: null,
Expand All @@ -197,7 +199,7 @@ export default class Selection extends React.PureComponent<Props, State> { // es
});

if (this.props.onSelectionChange) {
this.props.onSelectionChange(this.selectedChildren);
this.props.onSelectionChange(this.selectedChildren, endPoint);
}

if (this.props.onHighlightChange) {
Expand Down