embeddable mode #122
Open
embeddable mode #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/core
area/tooling
ecordell
force-pushed
the
noauth
branch
2 times, most recently
from
48f16b7 to
a23af9c
Compare
ecordell
force-pushed
the
noauth
branch
4 times, most recently
from
b740847 to
0043938
Compare
josephschorr
reviewed
Jul 2, 2025
since the existing e2e suite starts up a shared server for testing, I added a separate test just to validate the embedded mode
|
Added an e2e test that does kube client -> embedded proxy -> kube apiserver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an embedded mode that, if enabled, allows you to run the proxy in-process with another go application. Authentication is done via headers only in this mode (trusted because it's the same process) and provides helpers for generating clients that can access the embedded proxy.
When you execute an API call, the http request is buffered in memory for use by the application. I played some with lazily evaluating the request when the response body is read - this has the advantage of keeping memory low when streaming large responses, but the UX gets a little weird (i.e. can't read headers until 1 byte has been read from the body). It might be worth revisiting that approach in the future if needed.