more nits

Author: samliok

simplex/bls.go

@@ -2,6 +2,7 @@ package simplex
 
 import (
 	"encoding/asn1"
+	"errors"
 	"fmt"
 	"simplex"
 
@@ -10,7 +11,8 @@ import (
 )
 
 var (
-	errSignatureVerificationFailed = fmt.Errorf("signature verification failed")
+	errSignatureVerificationFailed = errors.New("signature verification failed")
+	errSignerNotFound              = errors.New("signer not found in the membership set")
 )
 
 type SignFunc func(msg []byte) (*bls.Signature, error)
@@ -81,7 +83,7 @@ func (v BLSVerifier) Verify(message []byte, signature []byte, signer simplex.Nod
 	key := ids.NodeID(signer)
 	pk, exists := v.nodeID2PK[key]
 	if !exists {
-		return fmt.Errorf("signer %x is not found in the membership set", key)
+		return fmt.Errorf("%w: signer %x", errSignerNotFound, key)
 	}
 
 	sig, err := bls.SignatureFromBytes(signature)

simplex/bls_test.go

@@ -18,7 +18,7 @@ type testValidatorInfo struct {
 	validators map[ids.NodeID]validators.Validator
 }
 
-func (v *testValidatorInfo) GetValidatorIDs(subnetID ids.ID) []ids.NodeID {
+func (v *testValidatorInfo) GetValidatorIDs(_ ids.ID) []ids.NodeID {
 	if v.validators == nil {
 		return nil
 	}
@@ -30,7 +30,7 @@ func (v *testValidatorInfo) GetValidatorIDs(subnetID ids.ID) []ids.NodeID {
 	return ids
 }
 
-func (v *testValidatorInfo) GetValidator(subnetID ids.ID, nodeID ids.NodeID) (*validators.Validator, bool) {
+func (v *testValidatorInfo) GetValidator(_ ids.ID, nodeID ids.NodeID) (*validators.Validator, bool) {
 	if v.validators == nil {
 		return nil, false
 	}
@@ -64,14 +64,14 @@ func newTestValidatorInfo(nodeIds []ids.NodeID, pks []*bls.PublicKey) *testValid
 func newEngineConfig(ls *localsigner.LocalSigner) *Config {
 	nodeID := ids.GenerateTestNodeID()
 
-	SimplexChainContext := SimplexChainContext{
+	simplexChainContext := SimplexChainContext{
 		NodeID:   nodeID,
 		ChainID:  ids.GenerateTestID(),
 		SubnetID: ids.GenerateTestID(),
 	}
 
 	return &Config{
-		Ctx:        SimplexChainContext,
+		Ctx:        simplexChainContext,
 		Validators: newTestValidatorInfo([]ids.NodeID{nodeID}, []*bls.PublicKey{ls.PublicKey()}),
 		SignBLS:    ls.Sign,
 	}
@@ -108,7 +108,7 @@ func TestSignerNotInMemberSet(t *testing.T) {
 
 	notInMembershipSet := ids.GenerateTestNodeID()
 	err = verifier.Verify([]byte(msg), sig, notInMembershipSet[:])
-	require.ErrorContains(t, err, "not found in the membership set")
+	require.ErrorIs(t, err, errSignerNotFound)
 }
 
 func TestSignerInvalidMessageEncoding(t *testing.T) {
@@ -125,6 +125,6 @@ func TestSignerInvalidMessageEncoding(t *testing.T) {
 	sigBytes := bls.SignatureToBytes(sig)
 
 	_, verifier := NewBLSAuth(config)
-	err = verifier.Verify([]byte(dummyMsg), sigBytes, config.Ctx.NodeID[:])
+	err = verifier.Verify(dummyMsg, sigBytes, config.Ctx.NodeID[:])
 	require.ErrorIs(t, err, errSignatureVerificationFailed)
 }