-
Notifications
You must be signed in to change notification settings - Fork 764
Comm Component for Simplex #3998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
dde076d
c5be0a4
5de26b1
52d343e
3f74024
d0f0102
458d540
49aa0bb
4dfdb34
475a5ef
8c78c03
14ad42f
2580d63
ed4422b
14aef3e
7d3484d
b13bc72
88b06d5
5f84156
3c362ea
03bdc02
ebdbfc9
7a7e5e7
d9b8a2c
c964299
12599d2
a3820e4
5119e93
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -181,6 +181,8 @@ type OutboundMsgBuilder interface { | |
chainID ids.ID, | ||
msg []byte, | ||
) (OutboundMessage, error) | ||
|
||
SimplexOutboundMessageBuilder | ||
} | ||
|
||
type outMsgBuilder struct { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated to this PR, but I have to say I am not sure I understand why this is an un-exported struct. it Makes it impossible to use anywhere in the code (for tests) and we also have only one concrete implementation of it. @StephenButtolph do you know why? |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than bloating this file up, i thought it would be cleaner to separate the simplex outbound messages into their own file