Skip to content

Comm Component for Simplex #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Jul 15, 2025
Merged

Comm Component for Simplex #3998

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
dde076d
add simplex pkg and bls structs
samliok Jun 5, 2025
c5be0a4
add simplex to go mod + lint
samliok Jun 5, 2025
5de26b1
added comm, writing tests
samliok Jun 5, 2025
52d343e
add log to createVerifier
samliok Jun 5, 2025
3f74024
add comm tests
samliok Jun 5, 2025
d0f0102
Merge branch 'master' into simplex-bls
samliok Jun 9, 2025
458d540
separate into utils file
samliok Jun 9, 2025
49aa0bb
style improvements
samliok Jun 10, 2025
4dfdb34
use GetValidatorSet for consistent validator set
samliok Jun 11, 2025
475a5ef
Merge branch 'master' into simplex-bls
samliok Jun 11, 2025
8c78c03
pass in membership set to config
samliok Jun 11, 2025
14ad42f
remove comment
samliok Jun 11, 2025
2580d63
Merge branch 'master' into simplex-bls
samliok Jun 12, 2025
ed4422b
test_util simplified
samliok Jun 12, 2025
14aef3e
add replication outbound msgs
samliok Jun 12, 2025
7d3484d
Merge branch 'simplex-bls' into simplex-comm
samliok Jun 12, 2025
b13bc72
lint
samliok Jun 12, 2025
88b06d5
go get
samliok Jun 12, 2025
5f84156
helper function + use testing in utils
samliok Jun 12, 2025
3c362ea
Merge branch 'simplex-bls' into simplex-comm
samliok Jun 12, 2025
03bdc02
Merge branch 'master' into simplex-comm
samliok Jun 18, 2025
ebdbfc9
merge conflicts and cleanup
samliok Jun 18, 2025
7a7e5e7
lint
samliok Jun 18, 2025
d9b8a2c
logs, and err clarification
samliok Jun 18, 2025
c964299
Merge branch 'master' into simplex-comm
samliok Jun 20, 2025
12599d2
add logging to config
samliok Jun 23, 2025
a3820e4
Merge branch 'master' into simplex-comm
samliok Jun 24, 2025
5119e93
Merge branch 'master' into simplex-comm
samliok Jun 30, 2025
84106b0
Merge branch 'master' into simplex-comm
samliok Jul 10, 2025
35c0161
rebase
samliok Jul 10, 2025
e8a91ec
rebase
samliok Jul 10, 2025
ad8ea62
sort nodes in place
samliok Jul 14, 2025
97c816b
update outbound message interface
samliok Jul 14, 2025
91ec652
stray away from mocks + lint
samliok Jul 14, 2025
55ddcdf
update message naming and add send helper
samliok Jul 15, 2025
2bf620b
update simplex
samliok Jul 15, 2025
03758ff
use set instead of array
samliok Jul 15, 2025
e1ba039
store both array and set
samliok Jul 15, 2025
3c2274c
Merge branch 'master' into simplex-comm
samliok Jul 15, 2025
bd94069
go mod tidy
samliok Jul 15, 2025
fb014e1
go mod
samliok Jul 15, 2025
898a29f
small nicts
samliok Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ require (
github.com/FactomProject/btcutilecc v0.0.0-20130527213604-d3a63a5752ec // indirect
github.com/Microsoft/go-winio v0.6.1 // indirect
github.com/VictoriaMetrics/fastcache v1.12.1 // indirect
github.com/ava-labs/simplex v0.0.0-20250605162940-db8e6d44f53d
github.com/beorn7/perks v1.0.1 // indirect
github.com/bits-and-blooms/bitset v1.10.0 // indirect
github.com/btcsuite/btcd/btcec/v2 v2.3.2 // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ github.com/ava-labs/coreth v0.15.2-rc.0.0.20250610170140-2fcf45f828a2 h1:/E1w2S6
github.com/ava-labs/coreth v0.15.2-rc.0.0.20250610170140-2fcf45f828a2/go.mod h1:cqwBag+zzqifDutdPVzZKovfC2d0L8Zxq4YgTGaMCwg=
github.com/ava-labs/ledger-avalanche/go v0.0.0-20241009183145-e6f90a8a1a60 h1:EL66gtXOAwR/4KYBjOV03LTWgkEXvLePribLlJNu4g0=
github.com/ava-labs/ledger-avalanche/go v0.0.0-20241009183145-e6f90a8a1a60/go.mod h1:/7qKobTfbzBu7eSTVaXMTr56yTYk4j2Px6/8G+idxHo=
github.com/ava-labs/simplex v0.0.0-20250605162940-db8e6d44f53d h1:D/BOS3USdAigun2OP/6khvukKnn4BIKviYAdKLHN6zc=
github.com/ava-labs/simplex v0.0.0-20250605162940-db8e6d44f53d/go.mod h1:GVzumIo3zR23/qGRN2AdnVkIPHcKMq/D89EGWZfMGQ0=
github.com/ava-labs/libevm v0.0.0-20250610142802-2672fbd7cdfc h1:cSXaUY4hdmoJ2FJOgOzn+WiovN/ZB/zkNRgnZhE50OA=
github.com/ava-labs/libevm v0.0.0-20250610142802-2672fbd7cdfc/go.mod h1:+Iol+sVQ1KyoBsHf3veyrBmHCXr3xXRWq6ZXkgVfNLU=
github.com/aymerick/raymond v2.0.3-0.20180322193309-b565731e1464+incompatible/go.mod h1:osfaiScAUVup+UC9Nfq76eWqDhXlp+4UYaA8uhTBO6g=
Expand Down
136 changes: 136 additions & 0 deletions message/messagemock/outbound_message_builder.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions message/outbound_msg_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ type OutboundMsgBuilder interface {
chainID ids.ID,
msg []byte,
) (OutboundMessage, error)

SimplexOutboundMessageBuilder
}

type outMsgBuilder struct {
Copy link
Contributor

@yacovm yacovm Jun 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but I have to say I am not sure I understand why this is an un-exported struct. it Makes it impossible to use anywhere in the code (for tests) and we also have only one concrete implementation of it.

@StephenButtolph do you know why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can utilize this in tests by using message.NewCreator.

Expand Down
Loading
Loading