Add BlockDatabase interface to database #4133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Jul 29, 2025
| // ReadBlock retrieves a block by its height. | ||
| ReadBlock(height uint64) ([]byte, error) | ||
|
|
||
| // ReadHeader retrieves only the header portion of a block by its height. |
There was a problem hiding this comment.
In avalanchego we also need to just read the block ID, which is used to service block dissemination.
I guess this header is only used for C-chain, but probably we should have yet another API call for the block ID...?
There was a problem hiding this comment.
I think we can keep this mapping data (id -> height) still stored in the key-value db. The blockdb can just store the bytes.
There was a problem hiding this comment.
yeah ReadHeader is specifically added for the c-chain since their interface allows reading header & body separately. However, I'm also exploring whether we can just not to support this, as the benefits appear to be minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Add an
BlockDatabaseinterface todatabasepackage. This will be used by the VMs to integrate x/blockdb.How this works
How this was tested
Need to be documented in RELEASES.md?
No