sync: coreth-archived PR #1178: enable state sync by default #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable state sync by default * add comment
| return errFirewoodOfflinePruningUnsupported | ||
| } | ||
| if vm.config.StateSyncEnabled { | ||
| if vm.config.StateSyncEnabled == nil || *vm.config.StateSyncEnabled { |
There was a problem hiding this comment.
the difference is rectified! annoyed me a couple months ago.
Comment on lines
-343
to
-347
| // NetworkID here is different than Avalanche's NetworkID. | ||
| // Avalanche's NetworkID represents the Avalanche network is running on | ||
| // like Fuji, Mainnet, Local, etc. | ||
| // The NetworkId here is kept same as ChainID to be compatible with | ||
| // Ethereum tooling. |
There was a problem hiding this comment.
this comment is not present in coreth, but not part of the original PR. I removed it to align the two repositories.
alarso16
approved these changes
Oct 14, 2025
|
After being educated by Stephen and Cey, I learned why this was a bad idea. Instead, I will do the far less harmful task of aligning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs: https://github.com/ava-labs/coreth-internal/pull/1178
Alternatively, syncs: ava-labs/coreth@cd3a14e#diff-6c4b2fd34f767685bfc35038a59ea4fbfadaa6060d70031002e3b008e73a06e7