Bring proof gen to fat clients #929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .map_err(|e| eyre::eyre!("Failed to create polynomial grid: {:?}", e))?; | ||
|
|
||
| let proofs = cells | ||
| .into_par_iter() |
There was a problem hiding this comment.
Are we okay with mixing rayon thread pool with tokio async tasks? Should we use tokio tasks to parallelise?
There was a problem hiding this comment.
sure will switch to tokio tasks
| @@ -40,6 +40,7 @@ libp2p = { version = "0.56.0", features = ["kad", "identify", "ping", "autonat", | |||
| libp2p-allow-block-list = "0.6.0" | |||
| libp2p-webrtc-websys = "0.4.0" | |||
| multihash = { version = "0.14.0", default-features = false, features = ["blake3", "sha3"] } | |||
| rayon = "1.11.0" | |||
There was a problem hiding this comment.
If this is only related to the multiproof feature, can we somehow exclude it when feature is not enabled?
Comment on lines
+58
to
+59
| kate = { workspace = true, default-features = true } | ||
| kate-recovery = { workspace = true, default-features = true } |
There was a problem hiding this comment.
Same question as for rayon dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.