Skip to content

[Http-Client] Use virtual thread executor by default #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[Http-Client] Use virtual thread executor by default #442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
870ec24
use virtual thread executor by default
SentryMan Jun 2, 2024
6c95ba8
only try if > 21
SentryMan Jun 4, 2024
dc7649d
[Http client] #442 extract helper method for newVirtualThreadPerTaskE…
rbygrave Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions http-client/src/main/java/io/avaje/http/client/DHttpClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,15 @@
import java.util.List;
import java.util.Optional;
import java.util.concurrent.Executor;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.function.Function;

import static java.util.Objects.requireNonNull;

import java.lang.invoke.MethodHandles;
import java.lang.invoke.MethodType;

final class DHttpClientBuilder implements HttpClient.Builder, HttpClient.Builder.State {

private java.net.http.HttpClient client;
Expand Down Expand Up @@ -99,6 +104,8 @@ private java.net.http.HttpClient defaultClient() {
}
if (executor != null) {
builder.executor(executor);
} else if (Integer.getInteger("java.specification.version") >= 21) {
builder.executor(virtualThreadExecutor());
}
if (proxy != null) {
builder.proxy(proxy);
Expand All @@ -118,6 +125,17 @@ private java.net.http.HttpClient defaultClient() {
return builder.build();
}

private static ExecutorService virtualThreadExecutor() {
try {
return (ExecutorService)
MethodHandles.lookup()
.findStatic(Executors.class, "newVirtualThreadPerTaskExecutor", MethodType.methodType(ExecutorService.class))
.invokeExact();
} catch (Throwable e) {
return null;
}
}

/**
* Create a reasonable default BodyAdapter if avaje-jsonb or Jackson are present.
*/
Expand Down
Loading