Better integration of Model into the other libraries #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ias; added support functions and property aliases; minor refactoring
|
I still need to do a smoke test |
|
This is a very promising concept, but it's gonna be on hold until after #110. |
Closed
avdstaaij
force-pushed
the
master
branch
4 times, most recently
from
c9219ee to
66745c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is the creation of
BlockGetterMixinandBlockPlacerMixin, which both provide virtual methods for getting and placing blocks respectively. This standardises these interactions across all classes that deal with blocks in a finite 3D space, such as the Model, Editor, and WorldSlice.In particular, the Model now acts as the de-facto data structure for passing multiple blocks between these three classes.