Skip to content

Add EasyMDE upload feature to the documentation #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erozas
Copy link

@erozas erozas commented Jan 21, 2025

This PR adds documentation for the EasyMDE upload feature.

It basically adds an image_upload boolean field to the field.

easy-mde-upload-docs

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for avo-v2-docs ready!

Name Link
🔨 Latest commit e39aef8
🔍 Latest deploy log https://app.netlify.com/sites/avo-v2-docs/deploys/678f80e0b1ee230008ce1330
😎 Deploy Preview https://deploy-preview-336--avo-v2-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unrelated changes there that shouldn't be present.
Please address those and we're pretty much good to go.

@@ -1,5 +1,5 @@
---
version: '1.0'
version: "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this change. We use standard to lint and it uses single quote.

Comment on lines 44 to 45
<Option name="`image_upload`">
If set to `true`, the editor will allow image uploads which will be uploaded using the direct uploads URL at `/rails/active_storage/direct_uploads`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space between these two for the markdown to work.

@@ -22,25 +22,36 @@ field :description, as: :easy_mde
The `easy_mde` field is hidden from the **Index** view.
:::

## Options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK why this change is like this


<Option name="`height`">
Sets the value of the editor

#### Default
### Default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this one


By default, the content of the `easy_mde` field is not visible on the `Show` view, instead, it's hidden under a `Show Content` link that, when clicked, displays the content. You can set `easy_mde` to always display the content by setting `always_show` to `true`.

<!-- @include: ./../common/default_boolean_false.md-->
</Option>
## Options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants