-
Notifications
You must be signed in to change notification settings - Fork 67
Add EasyMDE upload feature to the documentation #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for avo-v2-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some unrelated changes there that shouldn't be present.
Please address those and we're pretty much good to go.
docs/3.0/fields/easy_mde.md
Outdated
@@ -1,5 +1,5 @@ | |||
--- | |||
version: '1.0' | |||
version: "1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this change. We use standard
to lint and it uses single quote.
docs/3.0/fields/easy_mde.md
Outdated
<Option name="`image_upload`"> | ||
If set to `true`, the editor will allow image uploads which will be uploaded using the direct uploads URL at `/rails/active_storage/direct_uploads` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a space between these two for the markdown to work.
docs/3.0/fields/easy_mde.md
Outdated
@@ -22,25 +22,36 @@ field :description, as: :easy_mde | |||
The `easy_mde` field is hidden from the **Index** view. | |||
::: | |||
|
|||
## Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK why this change is like this
|
||
<Option name="`height`"> | ||
Sets the value of the editor | ||
|
||
#### Default | ||
### Default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this one
docs/3.0/fields/easy_mde.md
Outdated
|
||
By default, the content of the `easy_mde` field is not visible on the `Show` view, instead, it's hidden under a `Show Content` link that, when clicked, displays the content. You can set `easy_mde` to always display the content by setting `always_show` to `true`. | ||
|
||
<!-- @include: ./../common/default_boolean_false.md--> | ||
</Option> | ||
## Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this one
This PR adds documentation for the EasyMDE upload feature.
It basically adds an
image_upload
boolean field to the field.