Since the latest changes, I can no longer compile for LG webOS.

[satgit62]

@awawa-dev Hello,
Recently, I have been unable to compile the HyperHDR loader for webOS. The compilation process ends with a “Fatal Error.” See: https://github.com/satgit62/hyperhdr-webos-loader/actions/runs/17052046431/job/48341798041#step:8:292.

/home/runner/work/hyperhdr-webos-loader/hyperhdr-webos-loader/hyperhdr-repo/build/_deps/plutovg-src/source/plutovg-font.c:124:10: fatal error: threads.h: No such file or directory
  124 | #include <threads.h>
      |          ^~~~~~~~~~~
compilation terminated.
make[2]: *** [_deps/plutovg-build/CMakeFiles/plutovg.dir/build.make:127: _deps/plutovg-build/CMakeFiles/plutovg.dir/source/plutovg-font.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1387: _deps/plutovg-build/CMakeFiles/plutovg.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
Error: Process completed with exit code 2.

I noticed that you have completed the “Migrate ALL installers to QT6.8.3!” However, I believe that this is not relevant for building under WebOS. Am I mistaken?

Is this related to “plutovg depends” and “lunasvg,” or what has changed?
What do I need to provide to make compilation possible?
Previously, the following dependencies were required for successful compilation:

libpng16.so.16 libjpeg.so.8 libcrypto.so.1.1 libz.so.1 libssl.so.1.1 libQt5Sql.so.5.15.2 libpcre2-16.so. 0 libQt5Gui.so.5 libQt5Network.so.5 libQt5Widgets.so.5 libk5crypto.so.3 libatomic.so.1 libQt5Core.so.5 libkrb5support.so.0 libcom_err.so.3 libstdc++.so.6 libkrb5.so. 3 libQt5Sql.so.5 libgssapi_krb5.so.2 libQt5SerialPort.so.5 libQt5Sql.so.5.15 libusb-1.0.so.0 libturbojpeg.so.0

Is there anything missing here that I absolutely need to add?

Thank you in advance.

[awawa-dev]

Hi
I think it's related to crosscompiling and wrong conditions when checking if threads are available in this line: https://github.com/sammycage/lunasvg/blob/d89e70131a5d95d95ff7f0590b9d1312b6f519ca/plutovg/source/plutovg-font.c#L122 (your compiler has full C++11 support but webos SDK is missing threads)...some kind like sammycage/plutovg#56 but from other reasons, not sure why it worked before, it would be good that author add an option to disable that part of code

[awawa-dev]

Could you test if adding this line helps?
target_compile_definitions(plutovg PRIVATE __STDC_NO_THREADS__)
somewhere inside this if:

HyperHDR/external/CMakeLists.txt

Line 115 in 3e10535

set_target_properties(plutovg PROPERTIES POSITION_INDEPENDENT_CODE ON)

[satgit62]

Hello,
Thank you very much for your quick response and help.
I have no idea why it worked perfectly until now and now it doesn't.
By adding the following line in “HyperHDR Fork” (https://github.com/satgit62/HyperHDR/blob/master/external/CMakeLists.txt#L116), the action was completed and the problem was solved.
I am very grateful to you for this.
Will you implement the change in the future, or should I submit a pull request?

[awawa-dev]

Great! I can merge the workaround right away, but I'm thinking of an even more accurate alternative for detecting the existence of threads.h (so I don't have to disable them permanently, only when necessary). Could you test if it works? It should be placed in exactly the same place as in the previous version.

include(CheckIncludeFile)

check_include_file("threads.h" HAVE_THREADS_H)

if(NOT HAVE_THREADS_H)
    message(STATUS "threads.h not found → defining __STDC_NO_THREADS__ for plutovg target")
    target_compile_definitions(plutovg PRIVATE __STDC_NO_THREADS__)
endif()

[satgit62]

Great! I can merge the workaround right away, but I'm thinking of an even more accurate alternative for detecting the existence of threads.h (so I don't have to disable them permanently, only when necessary). Could you test if it works? It should be placed in exactly the same place as in the previous version.

include(CheckIncludeFile)

check_include_file("threads.h" HAVE_THREADS_H)

if(NOT HAVE_THREADS_H)
    message(STATUS "threads.h not found → defining __STDC_NO_THREADS__ for plutovg target")
    target_compile_definitions(plutovg PRIVATE __STDC_NO_THREADS__)
endif()

@awawa-dev Hello,
Please excuse the late reply. I only saw your response today.
Yes, it works with this change (https://github.com/satgit62/HyperHDR/blob/master/external/CMakeLists.txt#L116).
It didn't work at first because I only noticed later that there had to be a space after the “if” and an additional “endif()” at the end. After that, the action ran without errors.
Thank you very much for that.

[awawa-dev]

Thank you @satgit62 for testing. I've merged the changes.

[satgit62]

Hello @awawa-dev,
I'm wondering where I can disable the “USB capture” and “system screen capture” components so that they are not compiled and this is possible at all? These functions are not available in webOS anyway.

Thanks in advance.

[awawa-dev]

Hi
I wouldn't remove it from the components, but rather hide it in the interface if there are no grabbers (i.e. on the javascript side, which also has access to the HyperHDR configuration and is able to detect it) BTW take a look: #1261 but I dont think it will compile on webos if you have only Qt5.15 in your webos SDK :-/