Skip to content

feat(api): Add cause for graphql connection errors#3183

Merged
jvh-aws merged 12 commits intomainfrom
jv/add-cause-for-graphql-connection-errors
Feb 3, 2026
Merged

feat(api): Add cause for graphql connection errors#3183
jvh-aws merged 12 commits intomainfrom
jv/add-cause-for-graphql-connection-errors

Conversation

@jvh-aws
Copy link
Contributor

@jvh-aws jvh-aws commented Jan 21, 2026

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #2827

Description of changes:

  • Wrap GraphQL connection errors into GraphQLResponseException
  • Propagate cause up as part of ApiException on subscribe or query connection errors
  • Add tests

How did you test these changes?

  • Manual testing using reproducer app
    • Verified cause is provided for both network and not-authorized errors when establishing connection using queries / subscriptions
    • Verified error handling for GraphQL errors (after connection established) works, e.g. when response cannot be parsed due to schema out-of-sync issues
  • Unit tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jvh-aws jvh-aws requested review from a team as code owners January 21, 2026 10:45
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.81%. Comparing base (8c9039f) to head (d438f53).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3183      +/-   ##
==========================================
+ Coverage   54.79%   54.81%   +0.02%     
==========================================
  Files        1049     1050       +1     
  Lines       31361    31401      +40     
  Branches     4695     4699       +4     
==========================================
+ Hits        17183    17214      +31     
- Misses      12369    12378       +9     
  Partials     1809     1809              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jvh-aws jvh-aws requested a review from mattcreaser February 3, 2026 09:59
@jvh-aws jvh-aws merged commit 546bc44 into main Feb 3, 2026
17 checks passed
@jvh-aws jvh-aws deleted the jv/add-cause-for-graphql-connection-errors branch February 3, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants