Conversation
Existing approach for randomness isn't good enough
cadivus
force-pushed
the
test/auth-test-failure
branch
9 times, most recently
from
029b3f3 to
852b63b
Compare
cadivus
force-pushed
the
test/auth-test-failure
branch
from
852b63b to
7a1d4a3
Compare
Remove duplicate addTearDown(adminDeleteUser) calls from tests. AmplifyAuthTestPlugin.signUp already registers cleanup for every signUp call, so the explicit teardowns added in f4bcec3 caused each user to be deleted twice, producing UserNotFoundException. Also fix _oneOf() to return after first success instead of continuing to try all alternatives, which caused the same error in adminCreateUser's teardown (it tries both username and cognitoUsername, but the second always fails after the first succeeds).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve sign up tests to reduce flakyness