Skip to content

chore: Switch screenshot tests to Roborazzi #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 12, 2025
Merged

Conversation

mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented May 26, 2025

Issue #, if available:

Description of changes:
This PR switches the screenshot tests for Authenticator from Paparazzi to Roborazzi. This allows the tests to cohabitate in the component module with other tests, instead of requiring separation due to the conflict between Paprazzi and Robolectric. Now screenshot tests can shared the same utilities, setup, etc with regular Robolectric tests.

How did you test these changes?
PR should pass tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners May 26, 2025 16:00
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.39%. Comparing base (8d0aedd) to head (c083573).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   29.15%   32.39%   +3.24%     
==========================================
  Files          94       96       +2     
  Lines        4377     4448      +71     
  Branches      510      515       +5     
==========================================
+ Hits         1276     1441     +165     
+ Misses       2994     2892     -102     
- Partials      107      115       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vincetran vincetran merged commit f23f847 into main Jun 12, 2025
5 checks passed
@vincetran vincetran deleted the mattcreaser/roborazzi branch June 12, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants