Skip to content

fix(authenticator): Fix signin not happening after password reset#302

Merged
jvh-aws merged 2 commits intomainfrom
jv/fix-signin-not-happening-after-password-reset
Feb 17, 2026
Merged

fix(authenticator): Fix signin not happening after password reset#302
jvh-aws merged 2 commits intomainfrom
jv/fix-signin-not-happening-after-password-reset

Conversation

@jvh-aws
Copy link
Contributor

@jvh-aws jvh-aws commented Feb 13, 2026

Issue #, if available: #296

Description of changes: Fixes an issue where signin doesn't automatically happen after resetting the password. See #296

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jvh-aws jvh-aws requested review from a team as code owners February 13, 2026 16:15
}
} else {
moveTo(stateFactory.newSignInState(this::signIn))
}
Copy link
Contributor Author

@jvh-aws jvh-aws Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-introducing code removed in #287 that starts a signin job when handling password reset complete (here)

@jvh-aws jvh-aws merged commit 63e4569 into main Feb 17, 2026
4 of 5 checks passed
@jvh-aws jvh-aws deleted the jv/fix-signin-not-happening-after-password-reset branch February 17, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants