-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Labels
enhancementNew feature or requestNew feature or request
Description
I should be able to hard code a dimension (or use Fn::Sub) to specify a Dimension value, rather than always pull it from a log line.
Use cases:
- Filtering lambda logs that don't contain the function name.
- Attributing logs to deployment environments (prod, qa, etc)
This could be easily achieved by allowing non-selectors as dimension values (strings that don't start with $)
Currently if you try do do this you get:
metricName: `MemoryUsed`,
metricValue: "$some_value",
dimensions: {
FunctionName: `${node.ref}`
},
Resource handler returned message "invalid request provided: AWS::Logs::MetricFilter. Invalid metric transformation: dimension values must be valid selector.
So instead I need to inject the lambda name into the metric name - This makes looking for the metric and reporting on it a miserable experience, but to get it to works I have to do this :
metricName: `MemoryUsed-${node.ref}`,
metricValue: "$some_value",
greg5123334, rajataghi, jakob-keller, kingakimbrel, mbarneyjr and 17 more
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request