Skip to content

Onboarding and fixing new contract tests for AWS::SSM::Document #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Dashix111
Copy link
Contributor

Description of changes:

  • ensure new contract tests are passing by fixing ReadHandler permission
  • ensure new tagging contract tests are running and passing by
    • updating resource schema for tagging
    • fixing how ReadHandler handles access denied exception
  • pin aws-cloudformation-rpdk-java-plugin to 2.0.16 since newer versions are not compatible with JDK8

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Dashix111 Dashix111 closed this Jan 21, 2025
@Dashix111 Dashix111 reopened this Jan 21, 2025
@@ -28,7 +28,7 @@
<dependency>
<groupId>software.amazon.cloudformation</groupId>
<artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
<version>[2.0.0, 3.0.0)</version>
<version>2.0.16</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this upgrade in version will have any effect on any of the existing functionality. Asking as it seems its getting updated for all SSM service here.

Copy link
Contributor Author

@Dashix111 Dashix111 Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I think [2.0.0, 2.1.0) might be a better update, since 2.1.0 was the version causing issues. Updating all services otherwise build will fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants