adding tgw-attachment resource #48
Conversation
| rpdk.log | ||
| # contains credentials | ||
| sam-tests/ | ||
| build.gradle |
| "typeName": "AWS::EC2::TransitGatewayAttachment", | ||
| "description": "Resource Type definition for AWS::EC2::TransitGatewayAttachment", | ||
| "sourceUrl": "https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-transitgateway", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "Id": { | ||
| "type": "string" | ||
| }, | ||
| "TransitGatewayId": { | ||
| "type": "string" | ||
| }, | ||
| "VpcId": { | ||
| "type": "string" | ||
| }, | ||
| "SubnetIds": { | ||
| "type": "array", | ||
| "uniqueItems": false, | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, |
There was a problem hiding this comment.
is this AWS::EC2::TransitGatewayAttachment only for Vpc attachment or will also include VPN/Peering/DirectConnect attachment
There was a problem hiding this comment.
Only for VPCAttacment. Current Self-service resource is also for VPCAttachment but exists with the name AWS::EC2::TransitGatewayAttachment whereas the rest of them have their own individual names
There was a problem hiding this comment.
we should probably add in TransitGatewayAttachmentResourceType
There was a problem hiding this comment.
consider adding all the params for consistency with public API model https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/ec2/model/TransitGatewayAttachment.html
There was a problem hiding this comment.
if only for VPCattachment, should we just name it to be AWS::EC2::TransitGatewayVpcAttachment
There was a problem hiding this comment.
The missing parameters are for 1:1 mapping with original
| <dependency> | ||
|
|
||
| <groupId>software.amazon.awssdk</groupId> | ||
|
|
||
| <artifactId>ec2</artifactId> | ||
|
|
||
| <version>2.15.26</version> | ||
|
|
||
| </dependency> |
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.