Refactor AwsMetricAttributesSpanExporter to a processor #1250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
With the addition of
onEndingas part of the ExtendedSpanProcessor in OTel core (open-telemetry/opentelemetry-java#6367), we are now able to modify spans before they are sent to an exporter. As such, we have the opportunity to refactor ourAwsMetricAttributesSpanExporterwhich is responsible for adding service and dependency metric related attributes to spans as they are exported. This was done via some complicated span wrapping logic which is no longer necessary withonEnding.Changes
AwsMetricAttributesSpanExporterwithAwsAttributeGeneratingSpanProcessorAwsMetricAttributesSpanExportertoAwsAttributeGeneratingSpanProcessor, removing any exporter-related functionality and moving the span/attribute modification logic toprocessor.onEnding()AwsMetricAttributesSpanExporterBuilderwith theAwsAttributeGeneratingSpanProcessorBuilderTesting
Converted most of the exporter tests into equivalent tests for the new processor:
testPassthroughDelegationstestExportDelegatingSpanDataBehaviourtestExportDelegationWithMultipleSpanstestExportDelegationWithoutAttributeOrModification→testOnEndingGeneratesBothWithoutOverridetestExportDelegationWithAttributeButWithoutModification→testOnEndingGeneratesServicetestExportDelegationWithoutAttributeButWithModification→testOnEndingGeneratesBothWithoutOverridetestExportDelegationWithAttributeAndModification→testOnEndingGeneratesBothWithOverridetestOverridenAttributes→testOnEndingGeneratesBothWithOverridetestExportDelegationWithTwoMetrics→testOnEndingGeneratesBothWithTwoMetricstestConsumerProcessSpanHasEmptyAttribute→testConsumerSpanHasEmptyAttributestestExportDelegationWithDependencyMetrics→testOnEndingGeneratesDependencyAlso ran the entire main build workflow using this change successfully:
https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18785649764
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.