feat: add csp-violation-event-plugin#590
Open
anthony-ism wants to merge 1 commit intoaws-observability:mainfrom
Open
feat: add csp-violation-event-plugin#590anthony-ism wants to merge 1 commit intoaws-observability:mainfrom
anthony-ism wants to merge 1 commit intoaws-observability:mainfrom
Conversation
4c46345 to
0e39cd5
Compare
williazz
reviewed
Nov 12, 2024
| } | ||
|
|
||
| private addEventHandler(): void { | ||
| window.addEventListener('securitypolicyviolation', this.eventHandler); |
Collaborator
There was a problem hiding this comment.
Thanks for bringing attention to this new category of RUM events. This CR looks really good and I don't see any bugs at first glance.
However, I would like this plugin to be extensible for other security issues, and to use the best reporting tool available. From some quick research, I suspect that we should be monitoring security related issues using the ReportingObserver API. https://developer.mozilla.org/en-US/docs/Web/API/ReportingObserver
- Could you refactor from EventListeners to ReportingObserver?
- I suspect we should refactor this to a generic
SecurityPlugin, but add a configuration option if rum users want to record CSP Violations (by default disabled). This way, we can easily extend your plugin to capture other security events as necessary. - Last, for knowledge share, please let me know what other security telemetries you are interested in recording, so I can try to get priority.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new plugin,
CspViolationPluginthat is responsible for attaching its custom eventHandler to thesecuritypolicyviolationevent. https://developer.mozilla.org/en-US/docs/Web/API/Element/securitypolicyviolation_eventBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.