Skip to content

chore: Update idempotency examples for release 1..10.0 #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented May 9, 2024

Please provide the issue number

Issue number: #585

Summary

Changes

Update Idempotency examples for new release

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@auto-assign auto-assign bot requested review from amirkaws and sliedig May 9, 2024 11:51
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2024
@github-actions github-actions bot added the internal Maintenance changes label May 9, 2024
Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.20%. Comparing base (7a10387) to head (e07c64d).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #589      +/-   ##
===========================================
- Coverage    72.59%   72.20%   -0.40%     
===========================================
  Files          190      190              
  Lines         7901     7901              
  Branches       851      851              
===========================================
- Hits          5736     5705      -31     
- Misses        1874     1898      +24     
- Partials       291      298       +7     
Flag Coverage Δ
unittests 72.20% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit 0cdab3f into develop May 10, 2024
7 of 8 checks passed
@hjgraca hjgraca deleted the hjgraca-idempotency-examples branch May 10, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants