chore: Logging improved message formatting #869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #868
Summary
Changes
This pull request refactors logging to improve message template formatting and parameter handling. It also removes extra keys extensions code and ensures consistent usage of logging methods.
Refactoring for Logging Methods and Message Templates:
Updated multiple test cases (
LogFormatterTest.cs
,LogFormattingTests.cs
, andPowertoolsLoggerTest.cs
) to use consistent parameter ordering inLogInformation
,LogDebug
,LogTrace
, and other logging methods. This ensures that message templates and parameters are handled uniformly. [1] [2] [3] [4]Enhanced test cases to verify message template formatting and the inclusion of parameters in log outputs. Added a new test
TestMessageTemplateFormatting
inLogFormattingTests.cs
to validate single and multiple parameter scenarios.Improvements to Extra Keys Handling:
PowertoolsLoggerTest.cs
to ensure proper handling of extra keys (scopeKeys
) as part of the message template. This change standardizes the way extra keys are appended to log messages. [1] [2] [3]Dependency Updates:
Microsoft.Extensions.Logging
toLogFormatterTest.cs
to support the improved logging functionality.User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.