From ca64d128fb4b3bd35c9d23d3ab2503e74f48ef59 Mon Sep 17 00:00:00 2001 From: Eleni Dimitropoulou <12170229+eldimi@users.noreply.github.com> Date: Tue, 9 Jul 2024 11:54:58 +0300 Subject: [PATCH 1/2] Do not create SageMaker and StepFunctions endpoints when not needed --- lib/shared/index.ts | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/shared/index.ts b/lib/shared/index.ts index 8908cf18c..0342838aa 100644 --- a/lib/shared/index.ts +++ b/lib/shared/index.ts @@ -108,10 +108,12 @@ export class Shared extends Construct { }); // Create VPC Endpoint for SageMaker Runtime - vpc.addInterfaceEndpoint("SageMakerRuntimeEndpoint", { - service: ec2.InterfaceVpcEndpointAwsService.SAGEMAKER_RUNTIME, - open: true, - }); + if (props.config.llms.sagemaker.length > 0){ + vpc.addInterfaceEndpoint("SageMakerRuntimeEndpoint", { + service: ec2.InterfaceVpcEndpointAwsService.SAGEMAKER_RUNTIME, + open: true, + }); + } if (props.config.privateWebsite) { // Create VPC Endpoint for AppSync @@ -129,10 +131,11 @@ export class Shared extends Construct { service: ec2.InterfaceVpcEndpointAwsService.SNS, }); - // Create VPC Endpoint for Step Functions - vpc.addInterfaceEndpoint("StepFunctionsEndpoint", { - service: ec2.InterfaceVpcEndpointAwsService.STEP_FUNCTIONS, - }); + if(props.config.rag.enabled) { + vpc.addInterfaceEndpoint("StepFunctionsEndpoint", { + service: ec2.InterfaceVpcEndpointAwsService.STEP_FUNCTIONS, + }); + } // Create VPC Endpoint for SSM vpc.addInterfaceEndpoint("SSMEndpoint", { From d4aad8a58cfb76280fb03cc8648826af83b16afe Mon Sep 17 00:00:00 2001 From: Eleni Dimitropoulou <12170229+eldimi@users.noreply.github.com> Date: Mon, 19 Aug 2024 15:05:56 +0300 Subject: [PATCH 2/2] Fix linter findings --- lib/shared/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/shared/index.ts b/lib/shared/index.ts index ff50d17d1..dae2d9fff 100644 --- a/lib/shared/index.ts +++ b/lib/shared/index.ts @@ -108,7 +108,7 @@ export class Shared extends Construct { }); // Create VPC Endpoint for SageMaker Runtime - if (props.config.llms.sagemaker.length > 0){ + if (props.config.llms.sagemaker.length > 0) { vpc.addInterfaceEndpoint("SageMakerRuntimeEndpoint", { service: ec2.InterfaceVpcEndpointAwsService.SAGEMAKER_RUNTIME, open: true, @@ -131,7 +131,7 @@ export class Shared extends Construct { service: ec2.InterfaceVpcEndpointAwsService.SNS, }); - if(props.config.rag.enabled) { + if (props.config.rag.enabled) { vpc.addInterfaceEndpoint("StepFunctionsEndpoint", { service: ec2.InterfaceVpcEndpointAwsService.STEP_FUNCTIONS, });