Skip to content

Add additional Bedrock Knowedlge Base supported regions #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sleepwithcoffee
Copy link
Contributor

@sleepwithcoffee sleepwithcoffee commented Apr 21, 2025

Issue #, if available:

#652

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@maryamkhidir
Copy link
Collaborator

can you add a screenshot of this change in the cli?

@sleepwithcoffee
Copy link
Contributor Author

Image Image

@sleepwithcoffee
Copy link
Contributor Author

added support for the following regions:

export enum SupportedBedrockKnowledgeBaseRegion {
  AP_NORTHEAST_1 = "ap-northeast-1",
  AP_NORTHEAST_2 = "ap-northeast-2",
  AP_SOUTH_1 = "ap-south-1",
  AP_SOUTHEAST_1 = "ap-southeast-1",
  AP_SOUTHEAST_2 = "ap-southeast-2",
  CA_CENTRAL_1 = "ca-central-1",
  EU_CENTRAL_1 = "eu-central-1",
  EU_CENTRAL_2 = "eu-central-2",
  EU_NORTH_1 = "eu-north-1",
  EU_WEST_1 = "eu-west-1",
  EU_WEST_2 = "eu-west-2",
  EU_WEST_3 = "eu-west-3",
  US_EAST_1 = "us-east-1",
  US_EAST_2 = "us-east-2",
  US_WEST_2 = "us-west-2",
  SA_EAST_1 = "sa-east-1",
}

@Rob-Powell
Copy link
Contributor

The problem with just adding more bedrock regions is that not all functions are currently supported in all regions for example instance types used by batch not available consistently in all regions. #488
We should check that if we are enabling more regions the solution actually works in those regions

@sleepwithcoffee
Copy link
Contributor Author

hi @Rob-Powell this is Bedrock Knowledge Base region, isn't it different and should not impact in any way?

@Rob-Powell
Copy link
Contributor

hi @Rob-Powell this is Bedrock Knowledge Base region, isn't it different and should not impact in any way?

no, as batch is how the documents get into the knowledge base via the solution. I don't think it makes sense to enable more knowledge base bedrock regions, if we know they wont work for core use cases of the solution.

@sleepwithcoffee
Copy link
Contributor Author

thanks, that makes sense. Let me cross check and align with the list of existing regions for Bedrock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants