This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Minor doc updates for app discovery:#471
Open
rddefauw wants to merge 2 commits into
Open
Conversation
- Clarify proper working path - Clarify the IP address to use in the curl commands
buzzsurfr
suggested changes
Jun 7, 2018
Contributor
buzzsurfr
left a comment
buzzsurfr
left a comment
There was a problem hiding this comment.
Revert to , and reverse steps for clarity.
| http://<host>?greet=ho | ||
| http://<host>?id=1 | ||
| http://<host>?greet=ho&id=1 | ||
| http://<ingress> |
Contributor
There was a problem hiding this comment.
I think this should be left as <host>. We can add clarity around the instruction, such as running the kubectl get svc/webapp-service command first, then stating to use that value as <host>.
Contributor
Author
|
Reverted to using 'host' in the examples. |
Contributor
|
@buzzsurfr, Is this PR good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.