Skip to content

Commit 90dd0cd

Browse files
authored
Build fixes (#284)
* Deps: upgrade dependencies * Fix build warning * Fix empty zip errors Context: cdklabs/cdk-ecr-deployment#478 (comment)
1 parent 5ee6a4e commit 90dd0cd

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

PetAdoptions/cdk/pet_stack/lib/common/container-image-builder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export class ContainerImageBuilder extends Construct {
3232
repositoryName: props.repositoryName,
3333
imageScanOnPush: true,
3434
removalPolicy: cdk.RemovalPolicy.DESTROY,
35-
autoDeleteImages: true,
35+
emptyOnDelete: true,
3636
});
3737
const image = new ecrassets.DockerImageAsset(this, props.repositoryName + 'DockerImageAsset', {
3838
directory: props.dockerImageAssetDirectory
@@ -45,4 +45,4 @@ export class ContainerImageBuilder extends Construct {
4545
this.repositoryUri = repository.repositoryUri;
4646
this.imageUri = `${repository.repositoryUri}:latest`;
4747
}
48-
}
48+
}

PetAdoptions/cdk/pet_stack/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,21 @@
1414
"dependencies": {
1515
"@aws-cdk/aws-lambda-python-alpha": "^2.131.0-alpha.0",
1616
"@types/js-yaml": "^4.0.9",
17-
"aws-cdk-lib": "^2.131.0",
18-
"cdk-ecr-deployment": "^3.0.32",
17+
"aws-cdk-lib": "^2.146.0",
18+
"cdk-ecr-deployment": "^3.0.67",
1919
"jest": "^29.7.0",
2020
"js-yaml": "^4.1.0",
2121
"source-map-support": "^0.5.21"
2222
},
2323
"devDependencies": {
2424
"@types/jest": "^29.5.12",
25-
"@types/node": "^20.11.25",
26-
"aws-cdk": "^2.131.0",
27-
"cdk-nag": "^2.28.55",
25+
"@types/node": "^20.14.2",
26+
"aws-cdk": "^2.146.0",
27+
"cdk-nag": "^2.28.144",
2828
"constructs": "^10.3.0",
29-
"ts-jest": "^29.1.2",
29+
"ts-jest": "^29.1.5",
3030
"ts-node": "^10.9.2",
3131
"ts-replace-all": "^1.0.0",
32-
"typescript": "^5.4.2"
32+
"typescript": "^5.4.5"
3333
}
3434
}

buildspec.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
version: 0.2
2+
env:
3+
variables:
4+
# https://github.com/cdklabs/cdk-ecr-deployment/issues/478#issuecomment-1938020710
5+
NO_PREBUILT_LAMBDA: "1"
26
phases:
37
install:
48
commands:
@@ -15,4 +19,4 @@ phases:
1519
- cdk deploy Services --context admin_role=${EE_TEAM_ROLE_ARN} --context is_event_engine="true" --require-approval=never --verbose -O ./out/out.json
1620
- cdk deploy Applications --require-approval=never --verbose -O ./out/out.json
1721
artifacts:
18-
files: './PetAdoptions/cdk/pet_stack/out/out.json'
22+
files: "./PetAdoptions/cdk/pet_stack/out/out.json"

0 commit comments

Comments
 (0)