Template Upgrade error

[jam20m]

Describe the bug

When attempting to upgrade network-orchestration-hub.template from version v3beta01 to 3.3.16 the Cognito STNOUserPool Resource causes the template to rollback.

To Reproduce

Deploy v3beta01 - Prep for deployment of v3.3.16: Follow the build steps in the readme and output the amended templates and create the required zip files, console, graphql... and transfer to S3. Check the template params. Perform the update in cloudformation. Add and any additional params required and select update.

Expected behavior

Error Message:
Resource handler returned message: "Entity Type: USER, Message: AttributeName: User.custom:CognitoUserGr, DataType: STRING, Error: Attribute names MUST conform to the following rules: |ALPHA *(nameChar) and nameChar is "$" / "-" / "" /DIGIT / ALPHA

The issue relates to line 2384: Name: custom:CognitoUserGr
The colon causes the error. Adjusting the code to: Name: CognitoUserGr Allows the update to continue

Cloudtrail Error shows:
"errorCode": "InvalidParameterException",

"errorMessage": "Entity Type: USER, Message: AttributeName: User.custom:CognitoUserGr, DataType: STRING, Error: Attribute names MUST conform to the following rules: _\|ALPHA *(nameChar) and nameChar is \"$\" / \"-\" / \"_\" /DIGIT / ALPHA", },

• Version: [ 3.3.16]

• Region: ap-southeast-2

• Was the solution modified from the version published on this repository? YES

• If the answer to the previous question was yes, are the changes available on GitHub? NO

[jangidms]

Hi @jam20m
Thanks for reporting this.
We'll look into this and revert back

[jam20m]

To successfully complete the update of the hub from version 3beta01 to 3.3.16 I am rolling back the Cognito, Cloudfront, AppSync, and Console Resources before deploying the v3.3.16 template otherwise I had issues with the functionality of the console post deployment. The issue I found on line 2384: Name: custom:CognitoUserGr had no impact once the old resources were rolled back in this case, similarly this issue is not experienced if the template is deployed in a bare environment as you know.
As a suggestion, it would be nice if the line 385: S3Bucket: "%DIST_BUCKET_NAME%" were coded as a parameter value as shifting between builds and accounts it caught me out.