feat: add Windows support for os shim #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwoolum
commented
May 6, 2025
| #[cfg(windows)] | ||
| { | ||
| // Basic path joining | ||
| assert_append!("C:\\abc\\test", "test", "C:\\abc\\test\\test"); |
There was a problem hiding this comment.
I'm not sure of the actual intent of joining two absolute paths. Is this still relevant for Windows?
cwoolum
commented
May 6, 2025
| fs.remove_dir_all(&dir_link_path).await.unwrap(); | ||
| fs.remove_dir_all(&dir_link_sync_path).await.unwrap(); | ||
| }, | ||
| Err(e) if e.kind() == std::io::ErrorKind::PermissionDenied || e.raw_os_error() == Some(1314) => { |
There was a problem hiding this comment.
I catch permissions issues for tests so that VSCode doesn't need to be run as an admin but we can change this to force it. Another option is to just ensure that there are required permissions when pipeline actions run.
chaynabors
approved these changes
May 6, 2025
chaynabors
approved these changes
May 6, 2025
chaynabors
pushed a commit
that referenced
this pull request
May 9, 2025
Co-authored-by: Woolum <woolumc@amazon.com>
This was referenced May 9, 2025
chaynabors
added a commit
that referenced
this pull request
May 12, 2025
* Update login copy * chore: fix path to the dashboard README (#1696) * feat: add Windows support for os shim (#1714) Co-authored-by: Woolum <woolumc@amazon.com> * start telemetry, state, and settings refactor * finish rewrite * finish rewrite * finish rewrite (actually?) * change profile set copy * fix spellcheck lint --------- Co-authored-by: Kyosuke Konishi <86059523+Konippi@users.noreply.github.com> Co-authored-by: Chris Woolum <christopher.woolum@gmail.com> Co-authored-by: Woolum <woolumc@amazon.com>
brandonskiser
pushed a commit
that referenced
this pull request
May 12, 2025
* Update login copy * chore: fix path to the dashboard README (#1696) * feat: add Windows support for os shim (#1714) Co-authored-by: Woolum <woolumc@amazon.com> * start telemetry, state, and settings refactor * finish rewrite * finish rewrite * finish rewrite (actually?) * change profile set copy * fix spellcheck lint * finish chat persistence --------- Co-authored-by: Kyosuke Konishi <86059523+Konippi@users.noreply.github.com> Co-authored-by: Chris Woolum <christopher.woolum@gmail.com> Co-authored-by: Woolum <woolumc@amazon.com>
chaynabors
added a commit
that referenced
this pull request
May 12, 2025
* Update login copy * chore: fix path to the dashboard README (#1696) * feat: add Windows support for os shim (#1714) Co-authored-by: Woolum <woolumc@amazon.com> * start telemetry, state, and settings refactor * finish rewrite * finish rewrite * finish rewrite (actually?) * change profile set copy * fix spellcheck lint * finish chat persistence * chore: update rust dependencies --------- Co-authored-by: Kyosuke Konishi <86059523+Konippi@users.noreply.github.com> Co-authored-by: Chris Woolum <christopher.woolum@gmail.com> Co-authored-by: Woolum <woolumc@amazon.com>
cwoolum
added a commit
to cwoolum/amazon-q-developer-cli
that referenced
this pull request
May 13, 2025
* Update login copy * chore: fix path to the dashboard README (aws#1696) * feat: add Windows support for os shim (aws#1714) Co-authored-by: Woolum <woolumc@amazon.com> * start telemetry, state, and settings refactor * finish rewrite * finish rewrite * finish rewrite (actually?) * change profile set copy * fix spellcheck lint * finish chat persistence --------- Co-authored-by: Kyosuke Konishi <86059523+Konippi@users.noreply.github.com> Co-authored-by: Chris Woolum <christopher.woolum@gmail.com> Co-authored-by: Woolum <woolumc@amazon.com>
cwoolum
added a commit
to cwoolum/amazon-q-developer-cli
that referenced
this pull request
May 13, 2025
* Update login copy * chore: fix path to the dashboard README (aws#1696) * feat: add Windows support for os shim (aws#1714) Co-authored-by: Woolum <woolumc@amazon.com> * start telemetry, state, and settings refactor * finish rewrite * finish rewrite * finish rewrite (actually?) * change profile set copy * fix spellcheck lint * finish chat persistence * chore: update rust dependencies --------- Co-authored-by: Kyosuke Konishi <86059523+Konippi@users.noreply.github.com> Co-authored-by: Chris Woolum <christopher.woolum@gmail.com> Co-authored-by: Woolum <woolumc@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Windows support to the OS shim layer, enabling the Amazon Q Developer CLI to run natively on Windows platforms. This is a significant enhancement to our cross-platform compatibility and addresses user requests from the Windows
discussion thread.
Changes
• Implemented Windows-specific OS operations in the OS shim layer
• Added conditional compilation for Windows-specific code paths
• Ensured file path handling works correctly on Windows systems
• Maintained compatibility with existing Linux and macOS implementations
Testing
• Verified functionality on Windows 11
• Confirmed that existing Linux and macOS functionality remains intact
• Added new unit tests to verify Windows functionality
Related Issues
Continues work on #153