refactor: telemetry, state, and settings handling #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Woolum <woolumc@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
=======================================
Coverage 16.75% 16.75%
=======================================
Files 213 213
Lines 20704 20704
Branches 871 871
=======================================
Hits 3468 3468
Misses 17236 17236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaynabors
changed the title
brandonskiser
approved these changes
May 12, 2025
|
|
||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, serde::Serialize, serde::Deserialize)] | ||
| pub enum OAuthFlow { | ||
| DeviceCode, | ||
| // This must remain backwards compatible | ||
| #[serde(rename = "PKCE")] |
There was a problem hiding this comment.
Is this what was causing the different auth state while trying to login across the q and qchat binaries?
|
|
||
| #[ignore = "not in ci"] | ||
| #[tokio::test] | ||
| async fn logout_test() { |
There was a problem hiding this comment.
Why remove these tests? Useful for debugging
| ALTER TABLE state RENAME TO state_old; | ||
| CREATE TABLE state ( | ||
| key TEXT PRIMARY KEY, | ||
| value BLOB |
There was a problem hiding this comment.
Why are we making the state table store BLOB's? Is this really required?
some discussion on this - https://sqlite-users.sqlite.narkive.com/sBgPvXrZ/using-text-vs-blob
dingfeli
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async Channel Architecture - Replaced global state and mutex locks with a dedicated worker thread and message passing for non-blocking telemetry operations
Dependency Injection - Eliminated global singletons in favor of explicit dependencies for better testability, lifetime, and lifecycle management
Error Handling Improvements - Significantly improved error types and reduced error type sizes dramatically. This reduces the size of Result returned from almost every function in the codebase.
Database type: Greatly simplify local DB interaction and improve consistency across the codebase.
I've tested the fuck out of this but it's not enough. Will bug bash with the team.