feat: support Windows processes in mcp_client
#1765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwoolum
commented
May 10, 2025
| @@ -10,6 +12,11 @@ use super::{ | |||
| PidExt, | |||
| }; | |||
|
|
|||
| pub fn terminate_process(pid: Pid) -> Result<(), String> { | |||
There was a problem hiding this comment.
I duplicated this code for Unix and macOS since there are individual files for each OS. Not in love with it but it felt more cohesive than doing the OS specific logic in mod.rs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
=======================================
Coverage 16.75% 16.75%
=======================================
Files 213 213
Lines 20704 20704
Branches 871 871
=======================================
Hits 3468 3468
Misses 17236 17236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwoolum
changed the title
cwoolum
changed the title
mcp_client
cwoolum
force-pushed
the
main
branch
4 times, most recently
from
288ce1b to
e468ffd
Compare
cwoolum
force-pushed
the
main
branch
3 times, most recently
from
488926b to
5aea911
Compare
brandonskiser
requested changes
May 14, 2025
crates/chat-cli/Cargo.toml
Outdated
| @@ -64,6 +64,7 @@ dialoguer = { version = "0.11.0", features = ["fuzzy-select"] } | |||
| dirs = "5.0.0" | |||
| eyre = "0.6.8" | |||
| fd-lock = "4.0.4" | |||
| fig_util.workspace = true | |||
There was a problem hiding this comment.
Don't add fig_util as a chat-cli dependency, instead update whatever is required to support Windows inside what we have in chat-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-Platform Process Management for Windows Support
This PR adds cross-platform process management capabilities to support Windows in the Amazon Q Developer CLI. It addresses build issues that were occurring on Windows due to Unix-specific code.
Changes
Process Information Module
from_rawmethod to thePidstruct for consistent process ID handling across platformsterminate_processfunctions in their respective OS modules:killwithSIGTERMon Unix platforms (Linux and macOS)MCP Client
process_groupmethod conditional on Unix platformsterminate_processfunctionTesting
Continues work on #153